Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forms] Don't include <compat-auto> appearance tests for square-button / push-button / slider-horizontal #295

Closed
emilio opened this issue Mar 1, 2023 · 7 comments
Assignees
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area

Comments

@emilio
Copy link

emilio commented Mar 1, 2023

Test List

Rationale

These are tests for legacy values that are supposedly needed for compat:

https://drafts.csswg.org/css-ui-4/#typedef-appearance-compat-auto:

If any of these values are not needed for web compat, they should be dropped from this list; conversely, any value needed for compat not included in this list should be added.

Firefox doesn't implement these and we haven't seen any compat issue, so I'm proposing getting these removed from the spec in w3c/csswg-drafts#8506.

I don't think we want to implement these just for the sake of passing these tests, so I'd rather get them removed from the interop dashboard (or even from wpt altogether maybe).

@emilio emilio added the test-change-proposal Proposal to add or remove tests for an interop area label Mar 1, 2023
@nt1m
Copy link
Member

nt1m commented Mar 15, 2023

I would wait on w3c/csswg-drafts#8506 and remove these tests altogether from WPT if relevant.

@jgraham
Copy link
Contributor

jgraham commented Mar 16, 2023

Arguably if these properties are little used, and we don't expect/want that to change, we could remove the tests from interop either way. But it also seems fine to wait and see what the CSS-WG decision is.

@foolip
Copy link
Member

foolip commented Mar 30, 2023

@emilio we discussed this briefly in the interop team meeting today. This is blocked on w3c/csswg-drafts#8506, can you pull some strings to get it on the agenda in a meeting soon?

@foolip
Copy link
Member

foolip commented May 10, 2023

There's a resolution for w3c/csswg-drafts#8506 now. @emilio do you think we can update the tests right away, or wait for spec edit?

@emilio
Copy link
Author

emilio commented May 10, 2023

We can probably just update the tests right away.

@zcorpan zcorpan closed this as completed May 26, 2023
@foolip
Copy link
Member

foolip commented May 26, 2023

Tusen tack @zcorpan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants