Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appearance cssom tests that require the removal of values needed for compat #299

Closed
jensimmons opened this issue Mar 10, 2023 · 1 comment · Fixed by web-platform-tests/wpt#39120
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area

Comments

@jensimmons
Copy link
Contributor

Test List

https://wpt.fyi/results/css/css-ui/appearance-cssom-001.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2022-forms%20or%20label%3Ainterop-2023-forms

Rationale

We are failing four subtests because we support:

  • -webkit-appearance: -apple-pay-button
  • appearance: -apple-pay-button
  • -webkit-appearance: slider-vertical (invalid)
  • appearance: slider-vertical (invalid)

We will not be removing support for vertical sliders or Apple Pay buttons from WebKit. Doing so would create intolerable compat problems with existing sites and WebKit clients.

The Interop project is striving for interoperability between browsers. When one browser supports an optional non-standard value that another browser does not support, that state does not create an interoperability problem for web developers.

Whenever Interop and Compat are at odds, compat should win. We cannot break the web for the sake of tests.

@jensimmons jensimmons added the test-change-proposal Proposal to add or remove tests for an interop area label Mar 10, 2023
@nt1m
Copy link
Member

nt1m commented Mar 16, 2023

We could split the test in 2, one for legacy values (not included in Interop), one for values that need to be supported for compat.

nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2023
nt1m added a commit to web-platform-tests/wpt-metadata that referenced this issue Mar 22, 2023
github-actions bot pushed a commit to web-platform-tests/wpt-metadata that referenced this issue Mar 22, 2023
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 13, 2023
…ance values from appearance-cssom-001.html, a=testonly

Automatic update from web-platform-tests
Create variants to exclude legacy appearance values from appearance-cssom-001.html (#39120)

Fixes web-platform-tests/interop#299
--

wpt-commits: 5a142b8f762dbc853c9b64de3d494b7c56c94e6b
wpt-pr: 39120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
3 participants