Create variants to exclude legacy appearance values from appearance-cssom-001.html #39120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
approved these changes
Mar 21, 2023
nt1m
force-pushed
the
cssom-legacy-appearance-values
branch
2 times, most recently
from
64219a3
to
6ac5363
Compare
nt1m
changed the title
nt1m
force-pushed
the
cssom-legacy-appearance-values
branch
2 times, most recently
from
b06f4df
to
fa5f13b
Compare
nt1m
force-pushed
the
cssom-legacy-appearance-values
branch
from
fa5f13b
to
57d1cea
Compare
gsnedders
reviewed
Mar 22, 2023
Comment on lines
+5
to
+6
| <meta name="variant" content=""> | ||
| <meta name="variant" content="?exclude=Invalid"> |
There was a problem hiding this comment.
@nt1m this means there's some overlap between the two; it might be better to have ?include=Invalid instead of "".
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Mar 29, 2023
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes web-platform-tests/interop#299