-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create variants to exclude legacy appearance values from appearance-cssom-001.html #39120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Might be slightly nicer if this were variants, but I'm not overly fussed.
64219a3
to
6ac5363
Compare
b06f4df
to
fa5f13b
Compare
fa5f13b
to
57d1cea
Compare
<meta name="variant" content=""> | ||
<meta name="variant" content="?exclude=Invalid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nt1m this means there's some overlap between the two; it might be better to have ?include=Invalid
instead of ""
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes web-platform-tests/interop#299