Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carryover evaluation: Pointer and Mouse events #472

Closed
nairnandu opened this issue Sep 21, 2023 · 14 comments
Closed

Carryover evaluation: Pointer and Mouse events #472

nairnandu opened this issue Sep 21, 2023 · 14 comments
Labels
carryover-evaluation Evaluate whether to continue a focus area in the next year focus area: Pointer and Mouse Events

Comments

@nairnandu
Copy link
Contributor

To evaluate continuation of the Pointer & Mouse events focus area in Interop 2024

Original proposal:

Labeled tests (2023):

Also consider the possibility of adding new tests in 2024

@nairnandu nairnandu added focus area: Pointer and Mouse Events carryover-evaluation Evaluate whether to continue a focus area in the next year labels Sep 21, 2023
@foolip
Copy link
Member

foolip commented Sep 25, 2023

cc @hvanops @mustaqahmed

@foolip
Copy link
Member

foolip commented Sep 25, 2023

For reference, tests that aren't labeled, to consider for scope expansion:

@hsinyi
Copy link

hsinyi commented Sep 28, 2023

cc @smaug---- @EdgarChen

@mustaqahmed
Copy link
Member

Here is a snapshot of @foolip's queries above, where I have marked 29 out of 94 PointerEvents test for 2024:

@graouts @EdgarChen @smaug---- Please add your suggestions and comments in columns E-G there.
You can add new test names at the bottom too, just ignore the warning I added to prevent accidental edits.

@foolip
Copy link
Member

foolip commented Oct 5, 2023

Thank you @mustaqahmed!

@mustaqahmed
Copy link
Member

@masayuki-nakano I am seeing a new failing WPT on all browsers: dashboard

Do you think we can add it to the spreadsheet above for Interop 2024? I am asking because I don't know why this test is marked as "tentative".

(Here is the Chrome bug for the failure.)

@aprotyas
Copy link
Member

cc @nt1m @gsnedders @jensimmons

@nt1m
Copy link
Member

nt1m commented Oct 25, 2023

Here is a snapshot of @foolip's queries above, where I have marked 29 out of 94 PointerEvents test for 2024:

@graouts @EdgarChen @smaug---- Please add your suggestions and comments in columns E-G there. You can add new test names at the bottom too, just ignore the warning I added to prevent accidental edits.

A general comment on the spreadsheet is that we should not include tests for touch events in Interop 2024. We do not have the right infrastructure to test touch input. At least for Safari, it doesn't really make sense to test touch on a platform that does not support for touch (macOS).

@gsnedders
Copy link
Member

Likewise for pen input. There is no user or web developer need for Safari on macOS to support touch/pen input when macOS itself does not support touch or pen input.

@mustaqahmed
Copy link
Member

@nt1m and @gsnedders: based on your feedback, I excluded all tests that require touch/pen input. If you have any other suggestions, please comment in Column F.

After this update, our spreadsheet currently has 25 tests marked with #include: 23 in the first tab (for Pointer Events) plus 2 in the second tab (for Mouse Events).

@nairnandu
Copy link
Contributor Author

To summarize, these are the proposed additions. @jgraham @zcorpan @gsnedders @nt1m could you review?

  1. coalesced_events_attributes_under_load.https.html?mouse
  2. coalesced_events_attributes.html?mouse
  3. idlharness.window.html
  4. mouse-pointer-boundary-events-for-shadowdom.html
  5. pointerevent_after_target_appended.html?mouse
  6. pointerevent_attributes_hoverable_rightbutton.html?mouse
  7. pointerevent_auxclick_is_a_pointerevent.html?mouse
  8. pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html
  9. pointerevent_capture_suppressing_mouse.html
  10. pointerevent_click_during_capture.html
  11. pointerevent_click_is_a_pointerevent_multiple_clicks.html?mouse
  12. pointerevent_click_is_a_pointerevent.html?mouse
  13. pointerevent_constructor.html
  14. pointerevent_contextmenu_is_a_pointerevent.html?mouse
  15. pointerevent_fractional_coordinates.html?mouse
  16. pointerevent_mouse_capture_change_hover.html
  17. pointerevent_mouse_pointercapture_inactivate_pointer.html
  18. pointerevent_pointermove_on_chorded_mouse_button.html
  19. pointerevent_pointerout_no_pointer_movement.html
  20. pointerevent_releasepointercapture_events_to_original_target.html?mouse
  21. pointerevent_sequence_at_implicit_release_on_click.html?mouse
  22. pointerevent_touch-action-keyboard.html
  23. predicted_events_attributes.html?mouse
  24. synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html?buttonType=LEFT&button=0&buttons=1
  25. synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html?buttonType=MIDDLE&button=1&buttons=4

@nt1m
Copy link
Member

nt1m commented Feb 1, 2024

@nairnandu The carryover spreadsheet didn't mention any new scope for this focus area (it said "Carryover full scope", not "Carryover with new scope").

@nairnandu
Copy link
Contributor Author

nairnandu commented Feb 1, 2024

I don't believe we discussed this additional scope in our carryover evaluation. I will add it to the agenda for the meeting today

@jgraham
Copy link
Contributor

jgraham commented Feb 5, 2024

Note that although this issue is closed, the scope discussion is now happening in #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carryover-evaluation Evaluate whether to continue a focus area in the next year focus area: Pointer and Mouse Events
Projects
Status: Done
Development

No branches or pull requests

8 participants