-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable view=test mode in wpt.fyi (#190)
* Enable view=test mode in wpt.fyi * Update wptfyi_enable_view_eq_test.md * Update rfcs/wptfyi_enable_view_eq_test.md Co-authored-by: jgraham <james@hoppipolla.co.uk> --------- Co-authored-by: jgraham <james@hoppipolla.co.uk>
- Loading branch information
1 parent
a11a5d9
commit ae47868
Showing
1 changed file
with
38 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
## RFC 190: Enable view=test mode in wpt.fyi | ||
|
||
## Summary | ||
This RFC proposes enabling a new "test" view mode. This mode introduces a new method for counting total and failing tests, focusing on a strict pass/fail metric based on subtest counts. It includes frontend modifications to facilitate this change. This is to support this [feature request](https://github.com/web-platform-tests/wpt.fyi/issues/3740). | ||
|
||
## Details | ||
|
||
### Key Changes | ||
Currently, the feature is behind a feature flag that is set to false by default in production. | ||
* **Frontend Changes:** | ||
No frontend changes. This is will only be reachable by a query parameter that the end user must construct. | ||
|
||
### Background about "test" View Mode Behavior | ||
* Test pass is only registered when the number of passed subtests equals the total number of subtests. | ||
* Percentages are not displayed, only raw counts at the directory level. | ||
* Individual test level display: | ||
- Shows "PASS" only when subtest passes equal total subtests. | ||
- Shows "FAIL" when `status == OK` but subtest passes do not equal total subtests. | ||
- Existing `STATUS_ABBREVIATIONS` mappings used for other statuses. | ||
- "FAIL" as a fallback for any unmapped statuses. | ||
|
||
### How To Test The Change | ||
|
||
The feature has been enabled in staging by default so users can try it out. | ||
|
||
- Go to any page on https://staging.wpt.fyi that shows test counts | ||
- Add the view=test query parameter to the URL | ||
|
||
Examples: | ||
- https://staging.wpt.fyi/results/?label=experimental&label=master&aligned&view=test | ||
- https://staging.wpt.fyi/results/compat?label=experimental&label=master&aligned&view=test | ||
- https://staging.wpt.fyi/results/webstorage?label=experimental&label=master&aligned&view=test | ||
|
||
|
||
### Risks | ||
|
||
1. This new approach has different strengths and weaknesses to the long-standing default subtest view on wpt.fyi. | ||
- Mitigation: The default will remain unchanged to support current workflows and existing links. |