Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 182: Add WebDriver BiDi support to testdriver.js #182

Merged

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Feb 21, 2024

Add “testdriver.js” support for WebDriver BiDi events and actions.


Preview

@sadym-chromium sadym-chromium changed the title [NOT_READY_YET] RFC {N}: Allow WebDriver BiDi in testdriver.js [NOT_READY_YET] RFC 182: Allow WebDriver BiDi in testdriver.js Feb 21, 2024
@sadym-chromium sadym-chromium changed the title [NOT_READY_YET] RFC 182: Allow WebDriver BiDi in testdriver.js [NOT_READY_YET] RFC 182: Add WebDriver BiDi support to testdriver.js Feb 23, 2024
@sadym-chromium sadym-chromium changed the title [NOT_READY_YET] RFC 182: Add WebDriver BiDi support to testdriver.js RFC 182: Add WebDriver BiDi support to testdriver.js Feb 26, 2024
@sadym-chromium sadym-chromium marked this pull request as ready for review February 26, 2024 13:06
@sadym-chromium
Copy link
Contributor Author

@jgraham @gsnedders friendly ping

@foolip
Copy link
Member

foolip commented Mar 12, 2024

Given no feedback in 3 weeks this RFC has passed an I'll go ahead and merge it.

Feedback on the implementation and experience writing tests with this will probably require some additional changes, but I trust we can figure that out. I'm quite excited to see BiDi used to improve WPT testing capabilities, and want to see the next phase of this.

@foolip foolip merged commit b2da1b9 into web-platform-tests:master Mar 12, 2024
@sadym-chromium sadym-chromium deleted the sadym/testdriver-bidi branch March 12, 2024 10:22
@jgraham
Copy link
Contributor

jgraham commented Mar 12, 2024

I'm not happy with the unilateral merge here. This was brought up at the last infra meeting and there was a commitment to give feedback. Although I appreciate the letter of the process allows this, I don't think such unilateral action is in the spirit of collaboration, even though I understand that there can be frustration when people's internal priorities are blocked on community feedback. I'm going to revert this change and we can discuss further.

jgraham added a commit that referenced this pull request Mar 12, 2024
jgraham added a commit that referenced this pull request Mar 12, 2024
@jgraham
Copy link
Contributor

jgraham commented Mar 12, 2024

Reverted via #184 Unfortunately you'll need to create a new PR to continue this RFC.

@foolip
Copy link
Member

foolip commented Mar 12, 2024

I'm not happy with the unilateral merge here. This was brought up at the last infra meeting and there was a commitment to give feedback. Although I appreciate the letter of the process allows this, I don't think such unilateral action is in the spirit of collaboration, even though I understand that there can be frustration when people's internal priorities are blocked on community feedback. I'm going to revert this change and we can discuss further.

I was not in that meeting, so I didn't know about those commitments. Expedient review of #185 would be much appreciated.

On the process, it has a timeout in the absence of feedback for a reason, and I would expect it to be used by others if Google doesn't provide any feedback too.

@foolip
Copy link
Member

foolip commented Mar 12, 2024

I've filed #187 because the revert was outside of our documented process.

@sadym-chromium
Copy link
Contributor Author

@jgraham I'm sorry for the miscommunication happened on the meeting. I got the silence as "let's experiment with the proposed solution, and we can figure out details on the implementation stage".

@foolip foolip mentioned this pull request Mar 12, 2024
sadym-chromium added a commit to sadym-chromium/wpt_rfcs that referenced this pull request Mar 13, 2024
@sadym-chromium sadym-chromium mentioned this pull request Apr 11, 2024
sadym-chromium added a commit to sadym-chromium/wpt_rfcs that referenced this pull request Apr 11, 2024
foolip pushed a commit that referenced this pull request Apr 11, 2024
Roll back changes in readme from #182 and #183
sadym-chromium added a commit to sadym-chromium/wpt_rfcs that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants