Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to dismiss reviewer #9

Closed
gsnedders opened this issue Aug 17, 2017 · 3 comments
Closed

Unable to dismiss reviewer #9

gsnedders opened this issue Aug 17, 2017 · 3 comments

Comments

@gsnedders
Copy link
Member

For some directories, there's a bunch of different stuff in there and I'm not competent to review all of it, so I sometimes want to dismiss myself as a reviewer. However, when there's another push to the branch wpt-pr-bot readds me as a reviewer because I appear in a OWNERS file.

@tobie
Copy link
Contributor

tobie commented Aug 22, 2017

Just saw this today. Sorry.

I don't have a quick fix for this, tbh.

@zcorpan
Copy link
Member

zcorpan commented Jun 15, 2018

I see three ways to fix this.

  • Scrape the HTML of the pull request, looking for removed review requests.
  • Listen to https://developer.github.com/v3/activity/events/types/#pullrequestevent and record somehow that the review request was removed.
  • GET /repos/:owner/:repo/pulls/:number/requested_reviewers and avoid asking for more review requests if that is non-empty (but this would also not add the suggested reviewers if the PR author adds a review request).

Am I missing anything?

@gsnedders
Copy link
Member Author

One more option is to call https://developer.github.com/v3/issues/events/#list-events-for-an-issue and look through the events then, rather than recording somehow when the review request was removed.

zcorpan added a commit that referenced this issue Jun 15, 2018
zcorpan added a commit that referenced this issue Jun 15, 2018
zcorpan added a commit that referenced this issue Jun 15, 2018
jugglinmike pushed a commit that referenced this issue Jun 18, 2018
* Honor removed review request

Fixes #9.

* Address feedback and add the test

* Remove uneccessary sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants