Add structured search atom for filtering by results that differ #1463
Conversation
|
Staging deployment failed, so I can't test this live. |
|
|
||
|
|
||
|
|
||
| See [#meta-qualities](Meta qualities) above for more information on other |
There was a problem hiding this comment.
There's just different now, but is flaky one you want to add in the future?
| @@ -117,6 +117,15 @@ func (Link) Size() int { return 1 } | |||
| // Size of Count is the sum of the sizes of its constituent ConcretQuery instances. | |||
| func (c Count) Size() int { return size(c.Args) } | |||
|
|
|||
| // Size of Is depends on the quality. | |||
There was a problem hiding this comment.
What are these Size() methods for, what happens if they return the wrong value?
There was a problem hiding this comment.
The "size" of the query being performed; not sure exactly when it's used. @mdittmer could answer that.
api/query/concrete_query.go
Outdated
| @@ -117,6 +117,15 @@ func (Link) Size() int { return 1 } | |||
| // Size of Count is the sum of the sizes of its constituent ConcretQuery instances. | |||
| func (c Count) Size() int { return size(c.Args) } | |||
|
|
|||
| // Size of Is depends on the quality. | |||
| func (q MetadataQuality) Size() int { | |||
| switch q { | |||
There was a problem hiding this comment.
return 1 with a comment and/or assert would be better IMHO than scaffolding for extensions that may never come.
Co-Authored-By: Philip Jägenstedt <philip@foolip.org>
Are you expecting to see the comment from wpt-pr-bot? We've migrated to GitHub deployments already :)
|
|
Yes, I was expected the comments still, fail :) |
Fixes #1460
Description
Adds handling of
is:differentatom, which will return true for rows where the size/cardinality of the set of result statuses is not 1.Review Information