Add all/none root queries #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebjerring
commented
Sep 6, 2019
| } | ||
| } | ||
| { | ||
| var a AbstractAll |
There was a problem hiding this comment.
All / None re-used a/n, and the variables persisting makes for copy-pasta bugs, so I've scoped all the attempts. This (AbstractAll) and AbstractNone are added.
foolip
approved these changes
Sep 6, 2019
|
|
||
| `none` query objects perform a disjunction of all of the runs, in order to ensure | ||
| that no single run satisfies all of its queries. `none` queries are a simplification for | ||
| `{"not": {"exists": [...] }}` queries. |
| for _, run := range runs { | ||
| bound := arg.BindToRuns(run) | ||
| if _, ok := bound.(True); !ok { // And with True is pointless. | ||
| byRun = append(byRun, bound) |
There was a problem hiding this comment.
What kind of query hits this condition?
There was a problem hiding this comment.
There is a simplification behaviour when binding to runs (e.g. an empty OR becomes false) which this accounts for.
| } | ||
| } | ||
| { | ||
| var a AbstractAll |
| @@ -230,6 +230,26 @@ | |||
| }); | |||
| }); | |||
|
|
|||
| test('all', () => { | |||
| assertQueryParse('all(status:!PASS status:!OK)', { | |||
There was a problem hiding this comment.
Good example, I'd like to search for this :)
|
Force-merging to ignore Travis timeouts. |
foolip
added a commit
that referenced
this pull request
May 8, 2024
past
pushed a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1467
Description
Adds root query options for
allandnone(instead of the default,exists).Strangely,
countandseqget wrapped inexists. I started to tweak that behaviour, but decided against busying up the PR. Will clean that up another time.