Add support to search for web features in searchcache [Part 3/4] #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
reviewed
Jan 17, 2024
jcscottiii
force-pushed
the
jcscottiii/web-features-search-pt2
branch
from
32da8d1
to
d8bd9d3
Compare
jcscottiii
force-pushed
the
jcscottiii/web-features-search-pt3
branch
from
9d67f32
to
42c9201
Compare
The service will now interpret a query that takes the form of feature:<web-feature-key> Similarly to the searchcacheMetadataFetcher, there is now a searchcacheWebFeaturesManifestFetcher
Co-authored-by: Kyle Ju <kyleju@google.com>
jcscottiii
force-pushed
the
jcscottiii/web-features-search-pt3
branch
from
583b4dd
to
7d893db
Compare
jcscottiii
commented
Jan 22, 2024
|
This is ready for another review @KyleJu |
|
Chatted offline. The downloading Manifest bit can be moved to the shared/ directory |
Since most of the logic has been moved into shared, I was able to unexport a lot of things I thought I would need
|
Note to reviewers: Moving all the Github logic to shared allowed me to:
|
|
@KyleJu This is ready for another round |
KyleJu
approved these changes
Jan 24, 2024
Co-authored-by: Kyle Ju <kyleju@google.com>
When testing in my own repo, the Name field worked. But now that the wpt releases are automated, the label is the correct field
|
@KyleJu I added one more commit. I think it should be fine but don't want to assume. Let me know what you think of that commit |
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service will now interpret a query that takes the form of feature:
Similarly to the searchcacheMetadataFetcher, there is now a searchcacheWebFeaturesManifestFetcher