Skip to content

Commit

Permalink
Catch the exception and rethrow it after invoking custom elements rea…
Browse files Browse the repository at this point in the history
…ctions;

The spec was unclear on how CEReactions interact with thrown exceptions; see whatwg/html#3217.
The spec is now being clarified in whatwg/html#3235.

MozReview-Commit-ID: 521HprTRS7k

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1415761 [ci skip]
  • Loading branch information
EdgarChen authored and jgraham committed Nov 28, 2017
1 parent 2c0bcb0 commit 2c2254a
Showing 1 changed file with 31 additions and 0 deletions.
31 changes: 31 additions & 0 deletions custom-elements/reactions/with-exceptions.html
@@ -0,0 +1,31 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Custom Elements: CEReactions interaction with exceptions</title>
<link rel="author" title="Domenic Denicola" href="mailto:d@domenic.me">
<meta name="help" content="https://html.spec.whatwg.org/multipage/#cereactions">
<meta name="help" content="https://github.com/whatwg/html/pull/3235">

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../resources/custom-elements-helpers.js"></script>

<div id="log"></div>

<script>
"use strict";
// Basically from https://github.com/whatwg/html/issues/3217#issuecomment-343633273
test_with_window((contentWindow, contentDocument) => {
let reactionRan = false;
contentWindow.customElements.define("custom-element", class extends contentWindow.HTMLElement {
disconnectedCallback() {
reactionRan = true;
}
});
const text = contentDocument.createTextNode("");
contentDocument.documentElement.appendChild(text);
const element = contentDocument.createElement("custom-element");
contentDocument.documentElement.appendChild(element);
assert_throws("HierarchyRequestError", () => text.before("", contentDocument.documentElement));
assert_true(reactionRan);
}, "Reaction must run even after the exception is thrown");
</script>

0 comments on commit 2c2254a

Please sign in to comment.