Correct <form target=_blank> tests for noopener defaulting

See whatwg/html#7256 for context.
web-platform-tests · Oct 25, 2021 · 2c3823e · 2c3823e
1 parent 3311333
commit 2c3823e
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/content-security-policy/form-action/form-action-self-allowed-target-blank.html b/content-security-policy/form-action/form-action-self-allowed-target-blank.html
@@ -10,7 +10,8 @@
 <body>
   <form action='/content-security-policy/support/postmessage-pass-to-opener.html'
         id='form_id'
-        target="_blank">
+        target="_blank"
+        rel="opener">
   </form>
 
   <p>

diff --git a/content-security-policy/form-action/form-action-src-allowed-target-blank.sub.html b/content-security-policy/form-action/form-action-src-allowed-target-blank.sub.html
@@ -25,10 +25,9 @@
   </script>
 </head>
 <body onload="OnDocumentLoaded();">
-  <form id="form" method="GET" target="_blank">
+  <form id="form" method="GET" target="_blank" rel="opener">
     <input type="hidden" name="message" value="DocumentNotBlocked">
     <input type="submit" id="submit">
   </form>
 </body>
 </html>
-
diff --git a/content-security-policy/form-action/form-action-src-redirect-allowed-target-blank.sub.html b/content-security-policy/form-action/form-action-src-redirect-allowed-target-blank.sub.html
@@ -26,9 +26,8 @@
   </script>
 </head>
 <body onload="OnDocumentLoaded();">
-  <form id="form" method="POST" target="_blank">
+  <form id="form" method="POST" target="_blank" rel="opener">
     <input type="submit" id="submit">
   </form>
 </body>
 </html>
-
diff --git a/html/semantics/forms/form-submission-target/resources/reltester.js b/html/semantics/forms/form-submission-target/resources/reltester.js
@@ -1,3 +1,19 @@
+function formUsesTargetBlank(submitter) {
+  if (submitter.formTarget && submitter.formTarget === "_blank") {
+    return true;
+  }
+  if (submitter.form && submitter.form.target === "_blank") {
+    return true;
+  }
+  if (submitter.target && submitter.target === "_blank") {
+    return true;
+  }
+  if (submitter.getRootNode().querySelector("base").target === "_blank") {
+    return true;
+  }
+  return false;
+}
+
 function relTester(submitter, channelInput, title) {
   [
     {
@@ -51,7 +67,8 @@ function relTester(submitter, channelInput, title) {
           } else {
             assert_equals(e.data.referrer, "", "referrer");
           }
-          if (relTest.exposed === "all") {
+          // When rel is not explicitly given, account for target=_blank defaulting to noopener
+          if (relTest.exposed === "all" && !(relTest.rel === "" && formUsesTargetBlank(submitter))) {
             assert_true(e.data.haveOpener, "opener");
           } else {
             assert_false(e.data.haveOpener, "opener");