-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form with target=_blank and opener relationship #7256
Comments
Similarly, the following tests use a withtarget="_blank" and do not have rel="opener" , yet they expect the popup to have an opener:
|
Spotted while reading whatwg#7256 `targetAttributeValue` was never defined in this algorithm.
I suspect the problem is that this hasn't been implemented yet. Firefox still has https://bugzilla.mozilla.org/show_bug.cgi?id=1509346. That pointed to web-platform-tests/wpt#15356 for tests I wrote so I suspect we're in an inconsistent state on WPT. |
Note that there seems to be a typo in https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm:get-an-element's-noopener |
Created web-platform-tests/wpt#31368 and #7258 to address these. Review appreciated. |
Thank you for updating the tests. I am updating WebKit's behavior accordingly via https://bugs.webkit.org/show_bug.cgi?id=232243. |
…oopener defaulting, a=testonly Automatic update from web-platform-tests Correct <form target=_blank> tests for noopener defaulting See whatwg/html#7256 for context. -- wpt-commits: 2c3823e4038375bc18b17eece9cdbae0a270147a wpt-pr: 31368
…oopener defaulting, a=testonly Automatic update from web-platform-tests Correct <form target=_blank> tests for noopener defaulting See whatwg/html#7256 for context. -- wpt-commits: 2c3823e4038375bc18b17eece9cdbae0a270147a wpt-pr: 31368
See whatwg#7256 for context.
See whatwg#7256 for context.
I was investigating the following WPT test:
html/semantics/forms/form-submission-target/rel-input-target.html
In particular, the first subtest uses
<form rel="">
and a button that looks like<input type=submit formtarget=_blank>
.I would have expected the new window to NOT have an opener since target is _blank and rel does not include
opener
.However, the test seems the expect an opener here. Is this a bug in the test or am I misunderstanding the specification?
The relevant specification text seems to be:
which is called from:
The text was updated successfully, but these errors were encountered: