Skip to content

Commit

Permalink
Fix ICE bad port test in WebRTC (#45339)
Browse files Browse the repository at this point in the history 
The test used onicestatechange instead of oniceconnectionstatechange.
Also now runs on the full list of bad ports for completeness (thus requiring a long timeout)
  • Loading branch information
@dontcallmedom
dontcallmedom committed May 30, 2024
1 parent b3a2a57 commit 5317dc8
Showing 1 changed file with 105 additions and 29 deletions.
134 changes: 105 additions & 29 deletions webrtc/RTCPeerConnection-addTcpIceCandidate.html
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<!doctype html>
<title>Test RTCPeerConnection.prototype.addIceCandidate with TCP candidates</title>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="RTCPeerConnection-helper.js"></script>
Expand Down Expand Up @@ -27,69 +28,144 @@
a=ssrc:1001 cname:some
`;

const candidate_8001 = 'a=candidate:2983561038 1 tcp 1518214911 127.0.0.1 8001 typ host tcptype passive generation 0 ufrag 655Y network-id 1 network-cost 10';
// DRY: copied from fetch/api/request/request-bad-port.any.js
const BLOCKED_PORTS_LIST = [
1, // tcpmux
7, // echo
9, // discard
11, // systat
13, // daytime
15, // netstat
17, // qotd
19, // chargen
20, // ftp-data
21, // ftp
22, // ssh
23, // telnet
25, // smtp
37, // time
42, // name
43, // nicname
53, // domain
69, // tftp
77, // priv-rjs
79, // finger
87, // ttylink
95, // supdup
101, // hostriame
102, // iso-tsap
103, // gppitnp
104, // acr-nema
109, // pop2
110, // pop3
111, // sunrpc
113, // auth
115, // sftp
117, // uucp-path
119, // nntp
123, // ntp
135, // loc-srv / epmap
137, // netbios-ns
139, // netbios-ssn
143, // imap2
161, // snmp
179, // bgp
389, // ldap
427, // afp (alternate)
465, // smtp (alternate)
512, // print / exec
513, // login
514, // shell
515, // printer
526, // tempo
530, // courier
531, // chat
532, // netnews
540, // uucp
548, // afp
554, // rtsp
556, // remotefs
563, // nntp+ssl
587, // smtp (outgoing)
601, // syslog-conn
636, // ldap+ssl
989, // ftps-data
990, // ftps
993, // ldap+ssl
995, // pop3+ssl
1719, // h323gatestat
1720, // h323hostcall
1723, // pptp
2049, // nfs
3659, // apple-sasl
4045, // lockd
5060, // sip
5061, // sips
6000, // x11
6566, // sane-port
6665, // irc (alternate)
6666, // irc (alternate)
6667, // irc (default)
6668, // irc (alternate)
6669, // irc (alternate)
6697, // irc+tls
10080, // amanda
];

const candidate_2049 = 'a=candidate:2983561038 1 tcp 1518214911 127.0.0.1 2049 typ host tcptype passive generation 0 ufrag 655Y network-id 1 network-cost 10';

const candidate_37 = 'a=candidate:2983561038 1 tcp 1518214911 127.0.0.1 37 typ host tcptype passive generation 0 ufrag 655Y network-id 1 network-cost 10';
function candidateForPort(port) {
return `a=candidate:2983561038 1 tcp 1518214911 127.0.0.1 ${port} typ host tcptype passive generation 0 ufrag 655Y network-id 1 network-cost 10`;
}

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp + candidate_8001 + '\n'})
await pc.setRemoteDescription({type: 'offer', sdp: sdp + candidateForPort(8001) + '\n'})
const answer = await pc.createAnswer();
await pc.setLocalDescription(answer);
await waitForConnectionStateChangeWithTimeout(t, pc,
['failed', 'disconnected'], 1000);
}, 'TCP candidate aimed at port 8001 accepted');

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp + candidate_2049 + '\n'})
const answer = await pc.createAnswer();
await pc.setLocalDescription(answer);
pc.onicestatechange = t.unreached_func();
await new Promise(resolve => t.step_timeout(resolve, 500));
}, 'TCP candidate aimed at port 2049 ignored');

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp + candidate_37 + '\n'})
const answer = await pc.createAnswer();
await pc.setLocalDescription(answer);
pc.onicestatechange = t.unreached_func();
await new Promise(resolve => t.step_timeout(resolve, 500));
}, 'TCP candidate aimed at port 37 ignored');

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp})
const answer = await pc.createAnswer();
await pc.setLocalDescription(answer);
await pc.addIceCandidate(new RTCIceCandidate({
candidate: candidate_8001,
candidate: candidateForPort(8001),
sdpMid: 'audio1'
}));
await waitForConnectionStateChangeWithTimeout(
t, pc, ['failed', 'disconnected'], 1000);
}, 'TCP addIceCandidate aimed at port 8001 accepted');

for (const port of BLOCKED_PORTS_LIST) {
promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp + candidateForPort(port) + '\n'})
const answer = await pc.createAnswer();

await pc.setLocalDescription(answer);
pc.oniceconnectionstatechange = t.unreached_func();
await new Promise(resolve => t.step_timeout(resolve, 500));
}, `TCP candidate aimed at Fetch bad port ${port} ignored`);
}

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
await pc.setRemoteDescription({type: 'offer', sdp: sdp})
const answer = await pc.createAnswer();
await pc.setLocalDescription(answer);
await pc.addIceCandidate(new RTCIceCandidate({
candidate: candidate_2049,
candidate: candidateForPort(2049),
sdpMid: 'audio1'
}));
pc.onicestatechange = t.unreached_func();
pc.oniceconnectionstatechange = t.unreached_func();
await new Promise(resolve => t.step_timeout(resolve, 500));
}, 'TCP addIceCandidate aimed at port 2049 ignored');

}, `TCP addIceCandidate aimed at Fetch bad port 2049 ignored`);

</script>

0 comments on commit 5317dc8

Please sign in to comment.