Skip to content

Commit

Permalink
[Picture-in-Picture] Add test for consuming user gesture.
Browse files Browse the repository at this point in the history
This merge all request Picture-in-Picture tests into one test file and
adds one test to make sure user gesture is consumed by request
Picture-in-Picture so that a site couldn't produce a popup and a video
played in Picture-in-Picture on the same gesture.

Bug: 806249
Change-Id: Id974342b5cb48c1b60a44074d41603e93d2192e7
Reviewed-on: https://chromium-review.googlesource.com/909148
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535694}
  • Loading branch information
beaufortfrancois authored and chromium-wpt-export-bot committed Feb 9, 2018
1 parent 3e05847 commit 6fd9809
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 12 deletions.
11 changes: 0 additions & 11 deletions picture-in-picture/not-processing-user-gesture.html

This file was deleted.

18 changes: 17 additions & 1 deletion picture-in-picture/request-picture-in-picture.html
Expand Up @@ -9,5 +9,21 @@
<script>
promise_test(t => {
return requestPictureInPictureWithTrustedClick(document.createElement('video'));
});
}, 'request Picture-in-Picture resolves on user click');

promise_test(t => {
return promise_rejects(t, 'NotAllowedError',
document.createElement('video').requestPictureInPicture());
}, 'request Picture-in-Picture requires a user gesture');

promise_test(t => {
return callWithTrustedClick(() => {
const first = document.createElement('video').requestPictureInPicture();
const second = document.createElement('video').requestPictureInPicture();
return Promise.all([
first,
promise_rejects(t, 'NotAllowedError', second)
]);
});
}, 'request Picture-in-Picture consumes user gesture');
</script>

0 comments on commit 6fd9809

Please sign in to comment.