Skip to content

Commit

Permalink
Annotation model fixreqs (#4232)
Browse files Browse the repository at this point in the history
* Tightened tests for optional components of model

The schema definitions did not say that an item was required
so there were false positives in some cases - but only on optional
components of the model.

* Incorporated updates to address false positives

This essentially involves adding required entries to many of the
optional schema components.

* Tightened tests for optional components of model

The schema definitions did not say that an item was required
so there were false positives in some cases - but only on optional
components of the model.

* Remove Composite, List, Independent tests

Consistent with CR3 changes
  • Loading branch information
halindrome authored and sideshowbarker committed Dec 13, 2016
1 parent b1edb53 commit 98f9060
Show file tree
Hide file tree
Showing 91 changed files with 378 additions and 793 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@
}
]
}
}
},
"required": [ "target" ]
}
8 changes: 0 additions & 8 deletions annotation-model/annotations/annotationOptionals.test
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@
"annotations/bodiesTargets/3.2.4-bodyETB.json",
"annotations/bodiesTargets/3.2.4-bodyETBTypeTextualBody.json",
"annotations/bodiesTargets/3.2.4-bodyETBTypeText.json",
"annotations/bodiesTargets/3.2.7-bodyChoiceSet.json",
"annotations/bodiesTargets/3.2.7-bodyChoice.json",
"annotations/bodiesTargets/3.2.8-bodyList.json",
"annotations/bodiesTargets/3.2.8-bodyComposite.json",
"annotations/bodiesTargets/3.2.8-bodyIndependents.json",
"annotations/bodiesTargets/3.2.1-targSingleFormat.json",
"annotations/bodiesTargets/3.2.1-targSingleLanguage.json",
"annotations/bodiesTargets/3.3.1-targSingleCreator.json",
Expand All @@ -61,11 +57,7 @@
"annotations/bodiesTargets/3.3.7-targCanonical.json",
"annotations/bodiesTargets/3.3.7-targVia.json",
"annotations/bodiesTargets/3.2.1-targEWR.json",
"annotations/bodiesTargets/3.2.7-targChoiceSet.json",
"annotations/bodiesTargets/3.2.7-targChoice.json",
"annotations/bodiesTargets/3.2.8-targList.json",
"annotations/bodiesTargets/3.2.8-targComposite.json",
"annotations/bodiesTargets/3.2.8-targIndependents.json",
"annotations/bodiesTargets/4-bodySpecificResource.json",
"annotations/bodiesTargets/4-targSpecificResource.json",
"annotations/specificResource/4.3.3-refinedBy.json",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
{ "not": { "items": { "not": { "$ref": "bodyTarget.json#/definitions/itemEwrDetected" } } } }
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@
}
]
}
}
},
"required": [ "target" ]
}

This file was deleted.

This file was deleted.

This file was deleted.

29 changes: 0 additions & 29 deletions annotation-model/annotations/bodiesTargets/3.2.8-bodyList.json

This file was deleted.

This file was deleted.

This file was deleted.

28 changes: 0 additions & 28 deletions annotation-model/annotations/bodiesTargets/3.2.8-targList.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@

]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
}
]
}
}
},
"required": [ "target" ]
}
Loading

0 comments on commit 98f9060

Please sign in to comment.