Annotation model fixreqs #4232
Annotation model fixreqs #4232
Conversation
The schema definitions did not say that an item was required so there were false positives in some cases - but only on optional components of the model.
This essentially involves adding required entries to many of the optional schema components.
The schema definitions did not say that an item was required so there were false positives in some cases - but only on optional components of the model.
…atform-tests into annotation-model-fixreqs
|
Notifying @BigBlueHat, @halindrome, and @tcole3. |
Consistent with CR3 changes
|
@halindrome the fixreq fixes look fine. 👍 Should @tcole3's changes be added as a separate PR? Given that we're considering bringing back Composite, Independents, and List, I want to be sure we can simply revert that commit (or commits) to get the tests back. Thoughts? |
|
I am not too worried about losing those tests - they are in the web-annotation-test repo. |
|
I've finished double-checking that the changes in this PR, including the ones made to align with CR3 version of the model, work as expected. Regarding these last changes, I favor including in this PR. The deprecated keys (Composite, List, and Independents) are no longer in our context document and no longer in CR3 version of model. Tests can be retrieved if needed by developers. Presence of keys not an error, just won't count towards meeting CR exit criteria. |
These changes were already reviewed by the Web Annotation working group.
@tcole3 and @BigBlueHat please review so we can merge.