-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Subtract combobox display frame border-padding when inferring the hei…
…ght from line-height. This fixes it and seems to be an acceptable fix... Should I make it conditional on box-sizing: border-box for completeness? The display frame has border-box box-sizing, and not having it would be a bug, I'd think... Differential Revision: https://phabricator.services.mozilla.com/D41939 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764 gecko-commit: bd44d2dd0c02c1e2ab10e73695ee3ef1da971aa6 gecko-integration-branch: autoland gecko-reviewers: mats, jfkthame
- Loading branch information
1 parent
464774c
commit ade474e
Showing
3 changed files
with
70 additions
and
0 deletions.
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
html/rendering/replaced-elements/the-select-element/select-1-block-size-001-ref-2.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!doctype html> | ||
| <title>CSS Test Reference</title> | ||
| <link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io"> | ||
| <link rel="author" title="Mozilla" href="https://mozilla.org"> | ||
| <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1571764"> | ||
| <style> | ||
| div { | ||
| -webkit-appearance: none; | ||
| appearance: none; | ||
|
|
||
| background: black; | ||
| color: black; | ||
|
|
||
| line-height: 100px; | ||
| width: 100px; | ||
|
|
||
| border: 0; | ||
| padding: 0; | ||
|
|
||
| display: inline-block; | ||
| } | ||
| </style> | ||
| <div>A</div> | ||
| <div>A</div> |
23 changes: 23 additions & 0 deletions
23
html/rendering/replaced-elements/the-select-element/select-1-block-size-001-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!doctype html> | ||
| <title>CSS Test Reference</title> | ||
| <link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io"> | ||
| <link rel="author" title="Mozilla" href="https://mozilla.org"> | ||
| <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1571764"> | ||
| <link rel="match" href="select-1-block-size-001-ref-2.html"> | ||
| <style> | ||
| button { | ||
| -webkit-appearance: none; | ||
| appearance: none; | ||
|
|
||
| background: black; | ||
| color: black; | ||
|
|
||
| line-height: 100px; | ||
| width: 100px; | ||
|
|
||
| border: 0; | ||
| padding: 0; | ||
| } | ||
| </style> | ||
| <button>A</button> | ||
| <button>A</button> |
23 changes: 23 additions & 0 deletions
23
html/rendering/replaced-elements/the-select-element/select-1-block-size-001.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!doctype html> | ||
| <title>Select block size when line-height is specified</title> | ||
| <link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io"> | ||
| <link rel="author" title="Mozilla" href="https://mozilla.org"> | ||
| <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1571764"> | ||
| <link rel="match" href="select-1-block-size-001-ref.html"> | ||
| <style> | ||
| select { | ||
| -webkit-appearance: none; | ||
| appearance: none; | ||
|
|
||
| background: black; | ||
| color: black; | ||
|
|
||
| line-height: 100px; | ||
| width: 100px; | ||
|
|
||
| border: 0; | ||
| padding: 0; | ||
| } | ||
| </style> | ||
| <select></select> | ||
| <select><option>A</option></select> |