Skip to content

Commit

Permalink
Change |RebuildFragmentTreeSpine| to check |PhysicalFragmentCount|
Browse files Browse the repository at this point in the history
This patch changes |RebuildFragmentTreeSpine| to check
|PhysicalFragmentCount| instead of |CanUseNewLayout|.

This is consistent with the change for the subtree layout in
r890653 crrev.com/c/2934743, and can handle flow threads
correctly, because flow threads are not |LayoutNGMixin| even
when NG block fragmentation is enabled.

Bug: 965639, 829028
Change-Id: I8c9cdb16e37e67b7a0a9b0665e633d8eb200395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952733
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891728}
  • Loading branch information
kojiishi authored and chromium-wpt-export-bot committed Jun 11, 2021
1 parent 47390a2 commit e4979f6
Showing 1 changed file with 37 additions and 0 deletions.
37 changes: 37 additions & 0 deletions css/css-multicol/crashtests/multicol-dynamic-contain-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!DOCTYPE html>
<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
<link rel="help" href="https://crbug.com/965639">
<style>
#multicol {
columns: 2;
column-fill: auto;
height: 50px;
background: orange;
}
#container {
contain: strict;
width: 100px;
height: 100px;
background: blue;
}
#target {
width: 100px;
height: 100px;
position: absolute;
background: purple;
}
.transform {
transform: translate(0, 50px);
}
</style>
<body>
<div id="multicol">
<div id="container">
<div id="target"></div>
</div>
</div>
<script>
document.body.offsetTop;
target.appendChild(document.createTextNode('a'));
</script>
</body>

0 comments on commit e4979f6

Please sign in to comment.