Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement correct focus behavior for popovers
This implements the focus behavior described in [1], which: 1. Moves focus from an invoking element to its invoked popover, regardless of where in the DOM that popover lives. 2. Moves focus back to the next focusable element after the invoking element once focus leaves the invoked popover. 3. Skips over an open invoked popover otherwise. The logic follows very closely the case of slotted light DOM content, for which focus moves from the shadow root content to the slotted light DOM content and back. [1] https://github.com/w3c/html-aam/wiki/HTML-Popup-Attribute-A11y-Proposal-%28manual-and-auto%29 Bug: 1307772 Change-Id: Ic12441fc3b8d2f1c405bf912234dd24e4b05dc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4006714 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1069375}
- Loading branch information
1 parent
036e4ce
commit e9a622b
Showing
3 changed files
with
102 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9a622b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh! Looks like an error! Details
HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again.