Skip to content

Commit

Permalink
De-flake native-popup-with-datalist
Browse files Browse the repository at this point in the history
I was able to reproduce the flake which was happening because sometimes
the button was still focused. I fixed it by blurring the focused element
and adding a rAF.

Fixed: 334122678
Change-Id: Iede088900b888ab32c3a9554d5c6fc83b980ccc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530688
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300308}
  • Loading branch information
josepharhar authored and chromium-wpt-export-bot committed May 14, 2024
1 parent a2c4f68 commit ebdc4e7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
<script>
(async () => {
await test_driver.click(document.querySelector('select'));
document.activeElement.blur();
await new Promise(requestAnimationFrame);
document.documentElement.classList.remove('reftest-wait');
})();
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
<script>
(async () => {
await test_driver.click(document.querySelector('select'));
document.activeElement.blur();
await new Promise(requestAnimationFrame);
document.documentElement.classList.remove('reftest-wait');
})();
</script>

0 comments on commit ebdc4e7

Please sign in to comment.