idl_test uses Promise.finally, which isn't available in Edge 17 #12428
Assignees
Labels
Comments
foolip
added a commit
that referenced
this issue
Aug 13, 2018
With these 3 dependency orders, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: #12428
foolip
added a commit
that referenced
this issue
Aug 13, 2018
With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: #12428
foolip
added a commit
that referenced
this issue
Aug 13, 2018
With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: #12428
foolip
added a commit
that referenced
this issue
Aug 13, 2018
In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes #12428.
jgraham
pushed a commit
that referenced
this issue
Aug 13, 2018
In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes #12428.
foolip
added a commit
that referenced
this issue
Aug 13, 2018
…12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: #12428
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Aug 15, 2018
… idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes web-platform-tests/wpt#12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Aug 15, 2018
…grity/idlharness.window.js, a=testonly Automatic update from web-platform-testsFix dependency order in subresource-integrity/idlharness.window.js (#12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: web-platform-tests/wpt#12428 -- wpt-commits: 0419ed819c9e98114fac9dfadf5c7283107a9901 wpt-pr: 12429
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this issue
Aug 15, 2018
… idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes web-platform-tests/wpt#12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this issue
Aug 15, 2018
…grity/idlharness.window.js, a=testonly Automatic update from web-platform-testsFix dependency order in subresource-integrity/idlharness.window.js (#12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: web-platform-tests/wpt#12428 -- wpt-commits: 0419ed819c9e98114fac9dfadf5c7283107a9901 wpt-pr: 12429
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 3, 2019
… idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes web-platform-tests/wpt#12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432 UltraBlame original commit: 4a89638926789e52db93b8054e6020f6ef565c25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 3, 2019
…grity/idlharness.window.js, a=testonly Automatic update from web-platform-testsFix dependency order in subresource-integrity/idlharness.window.js (#12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: web-platform-tests/wpt#12428 -- wpt-commits: 0419ed819c9e98114fac9dfadf5c7283107a9901 wpt-pr: 12429 UltraBlame original commit: aca35b57deb2f37ba7541a7ca622aa32de4e4cfb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 3, 2019
… idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes web-platform-tests/wpt#12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432 UltraBlame original commit: 4a89638926789e52db93b8054e6020f6ef565c25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 3, 2019
…grity/idlharness.window.js, a=testonly Automatic update from web-platform-testsFix dependency order in subresource-integrity/idlharness.window.js (#12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: web-platform-tests/wpt#12428 -- wpt-commits: 0419ed819c9e98114fac9dfadf5c7283107a9901 wpt-pr: 12429 UltraBlame original commit: aca35b57deb2f37ba7541a7ca622aa32de4e4cfb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 3, 2019
… idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes web-platform-tests/wpt#12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432 UltraBlame original commit: 4a89638926789e52db93b8054e6020f6ef565c25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 3, 2019
…grity/idlharness.window.js, a=testonly Automatic update from web-platform-testsFix dependency order in subresource-integrity/idlharness.window.js (#12429) With these 3 dependencies, there is only one order which doesn't result in an error during setup, and this is it. The previous error was "ProcessingInstruction includes LinkStyle, but ProcessingInstruction is undefined.": https://wpt.fyi/results/subresource-integrity/idlharness.window.html?sha=eea0b54014&labels=stable Separate issue filed about the Edge failure: web-platform-tests/wpt#12428 -- wpt-commits: 0419ed819c9e98114fac9dfadf5c7283107a9901 wpt-pr: 12429 UltraBlame original commit: aca35b57deb2f37ba7541a7ca622aa32de4e4cfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #12272 a dependency on Promise.finally was added to
idl_test:https://github.com/web-platform-tests/wpt/blame/e9f3244421c353a63142dd9742e0ed6edc509cc8/resources/idlharness.js#L3224
Unfortunately, that's causing tests to fail in Edge 17:
https://wpt.fyi/results/encoding/idlharness.any.html?sha=eea0b54014&labels=stable
We need to achieve the same thing by some other means.
The text was updated successfully, but these errors were encountered: