Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step_timeout for "noopener" subresources #16933

Open
annevk opened this issue May 21, 2019 · 2 comments
Open

step_timeout for "noopener" subresources #16933

annevk opened this issue May 21, 2019 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented May 21, 2019

This is vaguely related to #10911.

There's a class of tests where you have a need for a timeout in a window that doesn't have access to the test instance. It would still be good for that window to use a slower timeout as Cloud infrastructure might require.

For this specific use case it might be good if this function was available in a standalone library you could pull in.

(I've seen folks pull in /resources/testharness.js instead, but while that works it will also lead to the subresources being a test as I understand it, which is not good.)

cc @jgraham

@annevk annevk added the infra label May 21, 2019
@jgraham
Copy link
Contributor

jgraham commented May 21, 2019

Also pulling in testharness.js doesn't work and will end up with the multiplier always set to 1 i.e. it's a no-op compared to just using setTimeout directly. So a better solution is needed here.

@foolip
Copy link
Member

foolip commented May 22, 2019

#5547 is relevant as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants