Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can step_timeout be used in reftests? #5547

Open
foolip opened this issue Apr 12, 2017 · 3 comments
Open

Can step_timeout be used in reftests? #5547

foolip opened this issue Apr 12, 2017 · 3 comments

Comments

@foolip
Copy link
Member

foolip commented Apr 12, 2017

In #5543 the lint said:

apng/animated-png-timeout.html:7: setTimeout used; step_timeout should typically be used instead (SET TIMEOUT)

There was 1 error (SET TIMEOUT: 1)
You must fix all errors; for details on how to fix them, see
https://github.com/w3c/web-platform-tests/blob/master/docs/lint-tool.md

However, instead of fixing a particular error, it's sometimes
OK to add a line to the lint.whitelist file in the root of the
web-platform-tests directory to make the lint tool ignore it.

For example, to make the lint tool ignore all 'SET TIMEOUT'
errors in the apng/animated-png-timeout.html file,
you could add the following line to the lint.whitelist file.

SET TIMEOUT:apng/animated-png-timeout.html

However, step_timeout is a part of testharness.js and including that would be strange even if it did work. (Not tested.) I added the suggested line to lint.whitelist.

@gsnedders @jgraham

@gsnedders
Copy link
Member

No, it can't be. But @jgraham's view was that it is worth linting for given the majority of tests are testharness.js tests, and we can't in general detect whether support files form part of a reftest or a testharness.js test. Except, like, this is a reftest and we can tell it is.

@foolip
Copy link
Member Author

foolip commented Apr 13, 2017

ci_lint.sh builds the manifest, but how is it used? Seems like it could be used for this.

@foolip
Copy link
Member Author

foolip commented May 31, 2017

This happened again in #6110 and I'll add that to the whitelist too. What would it take to just not do this check for reftests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants