Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear why pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html checks timestamp equality #17016

Closed
graouts opened this issue May 26, 2019 · 0 comments
Closed

Unclear why pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html checks timestamp equality #17016

graouts opened this issue May 26, 2019 · 0 comments
Labels
pointerevents wg-pointerevents

Comments

@graouts
Copy link
Contributor

graouts commented May 26, 2019

The test at pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html has this assertion:

test(function() {
  test(function () {
      assert_equals(event.timeStamp, last_pointer_event.timeStamp, "The time stamp of the compat mouse event should be the same as its pointerevent");
  });
}, event.type + "'s time stamp should be the same as " + last_pointer_event.type + "'s time stamp.");

However, I don't find anything in the Pointer Events specification that discusses that pointer events and compatibility mouse events should have the same timestamp. This should either be removed from the test or added to the spec. I've also raised a spec issue at w3c/pointerevents#284.
This was referenced May 26, 2019
Closed
Merged
graouts added a commit that referenced this issue May 28, 2019
@graouts
Remove the test that checks that pointer events and compatibility mou…
b89470b 
…se events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses #17016. (#17041)
@graouts graouts closed this as completed May 28, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 19, 2019
@graouts @jgraham
Bug 1554870 [wpt PR 17041] - Remove the test that checks that pointer…
43f3d45 
… events and compatibility mouse events have the same timestamp, a=testonly

Automatic update from web-platform-tests
Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041)

--

wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4
wpt-pr: 17041
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jun 19, 2019
@graouts @jgraham
Bug 1554870 [wpt PR 17041] - Remove the test that checks that pointer…
8c833cb 
… events and compatibility mouse events have the same timestamp, a=testonly

Automatic update from web-platform-tests
Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041)

--

wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4
wpt-pr: 17041
marcoscaceres pushed a commit that referenced this issue Jul 23, 2019
@graouts
Remove the test that checks that pointer events and compatibility mou…
79a3138 
…se events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses #17016. (#17041)
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1554870 [wpt PR 17041] - Remove the test that checks that pointer…
74e8c63 
… events and compatibility mouse events have the same timestamp, a=testonly

Automatic update from web-platform-tests
Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041)

--

wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4
wpt-pr: 17041

UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
@marco-c
Bug 1554870 [wpt PR 17041] - Remove the test that checks that pointer…
d30ab70 
… events and compatibility mouse events have the same timestamp, a=testonly

Automatic update from web-platform-tests
Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041)

--

wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4
wpt-pr: 17041

UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1554870 [wpt PR 17041] - Remove the test that checks that pointer…
65fbb30 
… events and compatibility mouse events have the same timestamp, a=testonly

Automatic update from web-platform-tests
Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041)

--

wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4
wpt-pr: 17041

UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pointerevents wg-pointerevents
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graouts