Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reftest.list files? #20060

Closed
smfr opened this issue Nov 2, 2019 · 2 comments · Fixed by #20066
Closed

Remove reftest.list files? #20060

smfr opened this issue Nov 2, 2019 · 2 comments · Fixed by #20066

Comments

@smfr
Copy link
Contributor

smfr commented Nov 2, 2019

I think reftest.list files are a vestige of Mozilla imports and aren't used any more. Should they be removed to avoid confusion?

wpt % find . -name reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/background/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/color4/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/text3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/filters/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/contain/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/will-change/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/align3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/ui3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/values3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/ib-split/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/text-decor-3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/sizing/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/conditional3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/break3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/css21/pagination/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/css21/replaced-sizing/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/css21/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/transforms/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/variables/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/images3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/fonts3/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/ruby/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/masking/reftest.list
./css/vendor-imports/mozilla/mozilla-central-reftests/multicol3/reftest.list
./css/css-backgrounds/background-attachment-local/reftest.list
./css/css-backgrounds/background-size/vector/empty/reftest.list
./css/css-backgrounds/background-size/vector/reftest.list
@jgraham
Copy link
Contributor

jgraham commented Nov 2, 2019

There is a plan to remove the vendor-imports directory but it would help not to make other changes to it in the interim. AFAIK it's OK to remove the other reftest.list files.

foolip added a commit that referenced this issue Nov 4, 2019
@foolip
[css] remove reftest.list files outside of vendor-imports
77ba1a5 
Fixes #20060.
@foolip foolip mentioned this issue Nov 4, 2019
Merged
foolip added a commit that referenced this issue Nov 4, 2019
@foolip
[css] remove reftest.list files outside of vendor-imports (#20066)
ad45b0f 
Fixes #20060.
@foolip
Copy link
Member

foolip commented Nov 4, 2019

I closed this with #20066, but @jgraham is there an issue that @smfr can follow about vendor-imports being merged into wpt proper?

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 29, 2019
@foolip @moz-wptsync-bot
Bug 1593630 [wpt PR 20066] - [css] remove reftest.list files outside …
406746a 
…of vendor-imports, a=testonly

Automatic update from web-platform-tests
[css] remove reftest.list files outside of vendor-imports (#20066)

Fixes web-platform-tests/wpt#20060.
--

wpt-commits: ad45b0fc499c93da8ede682af69f6fe31816e024
wpt-pr: 20066
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Nov 29, 2019
@foolip @moz-wptsync-bot
Bug 1593630 [wpt PR 20066] - [css] remove reftest.list files outside …
55827cf 
…of vendor-imports, a=testonly

Automatic update from web-platform-tests
[css] remove reftest.list files outside of vendor-imports (#20066)

Fixes web-platform-tests/wpt#20060.
--

wpt-commits: ad45b0fc499c93da8ede682af69f6fe31816e024
wpt-pr: 20066
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2019
@marco-c
Bug 1593630 [wpt PR 20066] - [css] remove reftest.list files outside …
169eaa4 
…of vendor-imports, a=testonly

Automatic update from web-platform-tests
[css] remove reftest.list files outside of vendor-imports (#20066)

Fixes web-platform-tests/wpt#20060.
--

wpt-commits: ad45b0fc499c93da8ede682af69f6fe31816e024
wpt-pr: 20066

UltraBlame original commit: 1c391f9d89b604c632b1488d08bf20dcaf4ed42f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2019
@marco-c
Bug 1593630 [wpt PR 20066] - [css] remove reftest.list files outside …
16ce486 
…of vendor-imports, a=testonly

Automatic update from web-platform-tests
[css] remove reftest.list files outside of vendor-imports (#20066)

Fixes web-platform-tests/wpt#20060.
--

wpt-commits: ad45b0fc499c93da8ede682af69f6fe31816e024
wpt-pr: 20066

UltraBlame original commit: 1c391f9d89b604c632b1488d08bf20dcaf4ed42f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2019
@marco-c
Bug 1593630 [wpt PR 20066] - [css] remove reftest.list files outside …
63c7d71 
…of vendor-imports, a=testonly

Automatic update from web-platform-tests
[css] remove reftest.list files outside of vendor-imports (#20066)

Fixes web-platform-tests/wpt#20060.
--

wpt-commits: ad45b0fc499c93da8ede682af69f6fe31816e024
wpt-pr: 20066

UltraBlame original commit: 1c391f9d89b604c632b1488d08bf20dcaf4ed42f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css] remove reftest.list files outside of vendor-imports web-platform-tests/wpt
3 participants
@smfr @jgraham @foolip