Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sink task failing for unclear reason #25610

Closed
marcoscaceres opened this issue Sep 18, 2020 · 4 comments
Closed

Sink task failing for unclear reason #25610

marcoscaceres opened this issue Sep 18, 2020 · 4 comments

Comments

@marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Sep 18, 2020

I'm wondering if someone can check why the sink task is failing in:
#25560

The taskcluster log doesn't seem to provide anything actionable (at least that I can see :( ):
https://community-tc.services.mozilla.com/tasks/UKR9mDn2TRyaynTB1U17rQ/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FUKR9mDn2TRyaynTB1U17rQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Sep 18, 2020

The sink-task is just how we make our dynamic task graph work with GitHub's requirement that we name a specific task as 'blocking' for PRs. (Sounds like I should document that clearer in the checks view!).

The actual failure will be the other failing Taskcluster checks. In your case, looks like that's wpt-firefox-nightly-stability. Clicking through to the details, payment-request/allowpayment/no-attribute-same-origin-bc-containers.https.html flaked. Given that all you did (I think?) was rename a variable + move the file, I'd consider this existing flake and am happy to admin-merge the PR if you would like :)

Loading

@jgraham
Copy link
Contributor

@jgraham jgraham commented Sep 18, 2020

We should make the sink task produce an artifact that explains this and links to the actual failures.

Loading

@jgraham
Copy link
Contributor

@jgraham jgraham commented Sep 18, 2020

Oh you said that, never mind me.

Loading

@marcoscaceres
Copy link
Contributor Author

@marcoscaceres marcoscaceres commented Sep 19, 2020

@stephenmcgruer, thanks for clarifying - that makes sense. I didn't realize they were dependent on each other. Would appreciate the merge of #25560, as we've updated the HTML spec and Payment Request Spec already.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants