-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-flexbox] issue with the references for gap-006-*? #26326
Comments
afaict, this is an interop issue that's unrelated to gap and is closer to flex alignment |
Can the references here be turned into test (for flex alignment) in themselves and the references changes to use some other technique that will be consistent? |
So what we need to do is (1) Take the current gap-006-ltr reference, make it a separate wpt and figure out why engines don't render it the same. @argyleink do you want to do this or do you want me to? |
confirmed, i can reproduce only with Firefox Nightly on Linux |
@stephenmcgruer is there a straightforward way to tell if this test has always been failing in Firefox, to rule out that it's just a regression in Nightly? (If it is then maybe the test could be left unchanged.) |
I recall that this has always been failing, but I am interested to hear how to query for that info :) |
And, I'm 99% sure this isn't a bug in Firefox, just an unfortunate effect of Chrome and Firefox giving the default font different sizes. We'll fix the reference to work in both browsers. |
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in #26326 Fixes web-platform-tests/wpt/#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in #26326 Fixes #26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in #26326 Fixes #26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830}
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in #26326 Fixes #26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830}
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in web-platform-tests/wpt#26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830}
…in firefox, a=testonly Automatic update from web-platform-tests [css-flex] Fix some gap tests that fail in firefox These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in web-platform-tests/wpt#26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830} -- wpt-commits: b9dea15062d348abb8da77996e8eb0bd4f9e5dec wpt-pr: 26371
…in firefox, a=testonly Automatic update from web-platform-tests [css-flex] Fix some gap tests that fail in firefox These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in web-platform-tests/wpt#26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830} -- wpt-commits: b9dea15062d348abb8da77996e8eb0bd4f9e5dec wpt-pr: 26371
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in web-platform-tests/wpt#26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830} GitOrigin-RevId: da0f2c9fda27a7cc85f122857c694353cb7ff77a
These are the tests in question: gap-006-lr.html, gap-006-ltr.html, gap-006-rl.html, gap-006-rtl.html
I'm interested in the Firefox failure, but included WebKitGTK and Servo results in case they provide clues. Here are the (cropped) actual and expected for gap-006-ltr.html in Firefox:
I suspect the problem here is really with the reference here, because when I open https://wpt.live/css/css-flexbox/gap-006-ltr.html or https://wpt.live/css/css-flexbox/gap-006-ltr-ref.html in Chrome or Safari, they look like the actual Firefox rendering.
The reference also uses Flexbox, so there's probably an interop issue here, but actually not with gap?
@argyleink (test author) @davidsgrogan @aethanyc would any of you like to take a look?
The text was updated successfully, but these errors were encountered: