Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change automatic reviewer of Web Crypto #27111

Closed
yacinehmito opened this issue Jan 8, 2021 · 11 comments · Fixed by #29080
Closed

Change automatic reviewer of Web Crypto #27111

yacinehmito opened this issue Jan 8, 2021 · 11 comments · Fixed by #29080
Assignees

Comments

@yacinehmito
Copy link
Contributor

yacinehmito commented Jan 8, 2021

When I submitted a PR on the Web Crypto tests (#27105), this automatically assigned Jim Schaab (handle jimshaab) as reviewer, which in turn sent an automatic email.
I was quickly informed by his brother that he sadly passed away in October, and was prompted to "Unsubscribe".

I don't know who is leading the project and can take the appropriate steps to replace Jim Schaab with someone else in the list of automatic reviewers of the Web Crypto tests.

Not only are the Web Crypto tests left without an owner at the moment, but more importantly it wouldn't be polite to keep sending automatic emails that his family will have to process.

@stephenmcgruer
Copy link
Contributor

Thanks for raising this @yacinehmito . I've sent #27113 to remove Jim from the META.yml file to stop sending emails to his family.

The spec (https://w3c.github.io/webcrypto/) unfortunately doesn't list many editors, but let me cc a few authors whom have made recent commits: @dontcallmedom @plehegar @Manishearth ; hopefully one of them can suggest a suitable owner.

@yacinehmito
Copy link
Contributor Author

Thank you for the swift response @stephenmcgruer.

jgraham pushed a commit that referenced this issue Jan 8, 2021
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 15, 2021
…, a=testonly

Automatic update from web-platform-tests
Remove jimshaab from WebCryptoAPI/META.yml

See web-platform-tests/wpt#27111

--

wpt-commits: 5c201a595befa12abd35054ba8a08b58021eec0b
wpt-pr: 27113
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jan 16, 2021
…, a=testonly

Automatic update from web-platform-tests
Remove jimshaab from WebCryptoAPI/META.yml

See web-platform-tests/wpt#27111

--

wpt-commits: 5c201a595befa12abd35054ba8a08b58021eec0b
wpt-pr: 27113

UltraBlame original commit: 75846beb72cab87fc5b2c31f4e152f42b3239d7a
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jan 29, 2021
…, a=testonly

Automatic update from web-platform-tests
Remove jimshaab from WebCryptoAPI/META.yml

See web-platform-tests/wpt#27111

--

wpt-commits: 5c201a595befa12abd35054ba8a08b58021eec0b
wpt-pr: 27113
@yacinehmito
Copy link
Contributor Author

@stephenmcgruer Shall the issue stay open until a reviewer is assigned?

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer Shall the issue stay open until a reviewer is assigned?

As WebCrypto now has no reviewers, I think it should. Again, I would really like to hear from one of the folks I tagged (@dontcallmedom @plehegar @Manishearth) as to whether there is a suitable person to review WebCrypto changes.

@Manishearth
Copy link
Contributor

I have only touched WebCrypto while propagating WebIDL changes, I know nothing of the spec

1 similar comment
@Manishearth
Copy link
Contributor

I have only touched WebCrypto while propagating WebIDL changes, I know nothing of the spec

@plehegar
Copy link
Member

I don't know enough about the spec to review the test.

@sideshowbarker
Copy link
Contributor

I can try to identify a suitable reviewer for Web Crypto tests

@sideshowbarker sideshowbarker self-assigned this Mar 1, 2021
@plehegar
Copy link
Member

@sideshowbarker , I believe you found someone. Can this be closed?

@sideshowbarker
Copy link
Contributor

@sideshowbarker , I believe you found someone. Can this be closed?

I found an editor to take responsibility for editing the spec, but I haven’t talked with him about also agreeing to take responsibility for reviewing tests. I’ll ask him.

@sideshowbarker
Copy link
Contributor

sideshowbarker commented May 22, 2021

@twiss Has agreed to be the suggested reviewer for tests in the WebCryptoAPI tree, so I’ve gone ahead and opened #29080 to make that so. As soon as that PR is reviewed and merged, it’ll auto-close this issue.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 27, 2021
…iel Huigens, a=testonly

Automatic update from web-platform-tests
Add WebCryptoAPI suggested reviewer: Daniel Huigens

Fixes web-platform-tests/wpt#27111

--

wpt-commits: c21b0b8ca7b8ba79b185547247f3ccf20081b414
wpt-pr: 29080
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 27, 2021
…iel Huigens, a=testonly

Automatic update from web-platform-tests
Add WebCryptoAPI suggested reviewer: Daniel Huigens

Fixes web-platform-tests/wpt#27111

--

wpt-commits: c21b0b8ca7b8ba79b185547247f3ccf20081b414
wpt-pr: 29080
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 29, 2021
…iel Huigens, a=testonly

Automatic update from web-platform-tests
Add WebCryptoAPI suggested reviewer: Daniel Huigens

Fixes web-platform-tests/wpt#27111

--

wpt-commits: c21b0b8ca7b8ba79b185547247f3ccf20081b414
wpt-pr: 29080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants