Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/dom/reflection-metadata.html needs adjusting #43286

Open
annevk opened this issue Nov 21, 2023 · 0 comments
Open

html/dom/reflection-metadata.html needs adjusting #43286

annevk opened this issue Nov 21, 2023 · 0 comments
Labels

Comments

@annevk
Copy link
Member

annevk commented Nov 21, 2023

There are quite a few tests here failing in all browsers.

I can in particular confirm that the nonce-related tests for the link and style elements are bogus and might have caused WebKit to not be aligned with the latest specification.

cc @mikewest

@annevk annevk added the html label Nov 21, 2023
webkit-commit-queue pushed a commit to annevk/WebKit that referenced this issue Nov 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=265173
rdar://118676659

Reviewed by Antti Koivisto.

Some leftover nonce IDL included [Reflect] and therefore those elements
had the older-but-now-bogus nonce semantics.

Tests have been synchronized and new tests in nonces.html are
upstreamed here:
web-platform-tests/wpt#43280

The new test failures in WPT html/dom/reflection-metadata.html are
expected and match all other browsers. I filed an upstream issue on
that test here:
web-platform-tests/wpt#43286

* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/nonce-hiding/nonce-hiding-move-document-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/nonce-hiding/nonce-hiding-move-document.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/nonce-hiding/nonces-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/nonce-hiding/nonces.html:
* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/nonce-hiding/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:
* Source/WebCore/html/HTMLLinkElement.idl:
* Source/WebCore/html/HTMLStyleElement.idl:

Canonical link: https://commits.webkit.org/271046@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant