Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization of drop-shadow #10099

Merged
merged 3 commits into from Mar 20, 2018

Conversation

Projects
None yet
4 participants
@csnardi
Copy link
Member

csnardi commented Mar 19, 2018

After w3c/fxtf-drafts#240, the serialization order of drop-shadow() was changed to be the color (if specified), then the length values. This matches the behavior of Firefox/Chrome/WebKit. Update the test to match this change to the spec.

Update serialization of drop-shadow
After w3c/fxtf-drafts#240, the serialization order of drop-shadow() was changed to be the color (if specified), then the length values. This matches the behavior of Firefox/Chrome/WebKit. Update the test to match this change to the spec.
@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Mar 19, 2018

@ericwilligers (I don't have access to request reviews)

Remove obsolete invalid parsing test for drop-shadow
w3c/fxtf-drafts#231 was resolved by allowing this grammar in the spec.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 19, 2018

Build PASSED

Started: 2018-03-19 18:15:57
Finished: 2018-03-19 18:20:21

View more information about this build on:

@ewilligers ewilligers merged commit c51eaff into web-platform-tests:master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:patch-9 branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.