Make BlueTooth/USB requestDevice non-consuming. #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 21, 2018
Build PASSEDStarted: 2018-03-29 17:05:49 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-775866
branch
from
e1d005f
to
1e84935
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-775866
branch
from
1e84935
to
e761082
Compare
The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call. So consuming the activation
(vs just checking) is not a strong requirement. There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully. Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.
Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway. This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.
Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548768}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-775866
branch
from
e761082
to
c342c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call. So consuming the activation
(vs just checking) is not a strong requirement. There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully. Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.
Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway. This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.
Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866
Reviewed-by: Reilly Grant reillyg@chromium.org
Reviewed-by: Giovanni Ortuño Urquidi ortuno@chromium.org
Commit-Queue: Mustaq Ahmed mustaq@chromium.org
Cr-Commit-Position: refs/heads/master@{#548768}