Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BlueTooth/USB requestDevice non-consuming. #10130

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 21, 2018

The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call. So consuming the activation
(vs just checking) is not a strong requirement. There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully. Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.

Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway. This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.

Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866
Reviewed-by: Reilly Grant reillyg@chromium.org
Reviewed-by: Giovanni Ortuño Urquidi ortuno@chromium.org
Commit-Queue: Mustaq Ahmed mustaq@chromium.org
Cr-Commit-Position: refs/heads/master@{#548768}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 21, 2018

Build PASSED

Started: 2018-03-29 17:05:49
Finished: 2018-03-29 17:15:46

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-775866 branch from e1d005f to 1e84935 Mar 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Make BlueTooth/USB requestDevice check activation w/o consuming. Make BlueTooth/USB requestDevice non-consuming. Apr 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-775866 branch from 1e84935 to e761082 Apr 5, 2018

@wpt-pr-bot wpt-pr-bot added the webusb label Apr 5, 2018

Make BlueTooth/USB requestDevice non-consuming.
The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call.  So consuming the activation
(vs just checking) is not a strong requirement.  There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully.  Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.

Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway.  This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.

Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548768}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-775866 branch from e761082 to c342c1c Apr 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6ba01ea into master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-775866 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.