New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AudioNode tests to WPT #10320

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 4, 2018

Move the AudioNode tests to WPT.

Can't move tail-processing.html because it's specific to Chrome's tail
processing.

Firefox passes all tests except:

  • audionode.html (because new AudioContext(1,44100,44100) succeeds but
    shouldn't
  • tests that use oac.suspend
  • audionode-connect-method-chaining.html with an IndexSizeError
    connecting

Bug: 745778
Change-Id: I0e21e2117a75246367ea2642759ed917ee3e028f
Reviewed-on: https://chromium-review.googlesource.com/994136
Reviewed-by: Hongchan Choi hongchan@chromium.org
Reviewed-by: Dirk Pranke dpranke@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#548843}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 5, 2018

Build PASSED

Started: 2018-04-04 23:46:23
Finished: 2018-04-04 23:57:01

View more information about this build on:

Move AudioNode tests to WPT
Move the AudioNode tests to WPT.

Can't move tail-processing.html because it's specific to Chrome's tail
processing.

Firefox passes all tests except:

* audionode.html (because new AudioContext(1,44100,44100) succeeds but
  shouldn't
* tests that use oac.suspend
* audionode-connect-method-chaining.html with an IndexSizeError
  connecting

Bug: 745778
Change-Id: I0e21e2117a75246367ea2642759ed917ee3e028f
Reviewed-on: https://chromium-review.googlesource.com/994136
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548843}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 68b0798 into master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-994136 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment