Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-transitions] Split up with variant, set long timeout, rename manual tests #11057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions css/css-transitions/properties-value-001.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>CSS Transitions Test: Intermediate Property Values</title>
<meta name="timeout" content="long">
<meta name="assert" content="Test checks that value ranges between start and end while transitioning">
<link rel="help" title="2. Transitions" href="http://www.w3.org/TR/css3-transitions/#transitions">
<link rel="help" title="7.1. Properties from CSS" href="http://www.w3.org/TR/css3-transitions/#animatable-css">
Expand Down
1 change: 1 addition & 0 deletions css/css-transitions/properties-value-inherit-001.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>CSS Transitions Test: transitioning inherited property values</title>
<meta name="timeout" content="long">
<meta name="assert" content="Test checks that inherited property values that are transitioned on a parent element don't start a transition">
<link rel="help" title="3. Starting of transitions" href="http://www.w3.org/TR/css3-transitions/#starting">
<link rel="author" title="Rodney Rehm" href="http://rodneyrehm.de/en/">
Expand Down
1 change: 1 addition & 0 deletions css/css-transitions/properties-value-inherit-002.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>CSS Transitions Test: transitioning inherited property values</title>
<meta name="timeout" content="long">
<meta name="assert" content="Test checks that inherited property values that are not transitioned on a parent element start a transition">
<link rel="help" title="3. Starting of transitions" href="http://www.w3.org/TR/css3-transitions/#starting">
<link rel="author" title="Rodney Rehm" href="http://rodneyrehm.de/en/">
Expand Down
1 change: 1 addition & 0 deletions css/css-transitions/properties-value-inherit-003.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>CSS Transitions Test: transitioning implicitly inherited property values</title>
<meta name="timeout" content="long">
<meta name="assert" content="Test checks that implicitly inherited property values that are transitioned on a parent element don't start a transition">
<link rel="help" title="3. Starting of transitions" href="http://www.w3.org/TR/css3-transitions/#starting">
<link rel="author" title="Rodney Rehm" href="http://rodneyrehm.de/en/">
Expand Down
58 changes: 53 additions & 5 deletions css/css-transitions/transitions-animatable-properties-01.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,56 @@
<html>
<!-- Submitted from TestTWF Paris -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove comment while you're here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<meta charset="utf-8">
<title> CSS Transitions: Animatable CSS properties </title>
<meta name="timeout" content="long">
<meta name="variant" content="?background-color">
<meta name="variant" content="?background-position">
<meta name="variant" content="?border-color">
<meta name="variant" content="?border-bottom-color">
<meta name="variant" content="?border-bottom-width">
<meta name="variant" content="?border-left-color">
<meta name="variant" content="?border-left-width">
<meta name="variant" content="?border-right-color">
<meta name="variant" content="?border-right-width">
<meta name="variant" content="?border-spacing">
<meta name="variant" content="?border-top-color">
<meta name="variant" content="?border-top-width">
<meta name="variant" content="?bottom">
<meta name="variant" content="?clip">
<meta name="variant" content="?color">
<meta name="variant" content="?crop">
<meta name="variant" content="?font-size">
<meta name="variant" content="?font-weight">
<meta name="variant" content="?height">
<meta name="variant" content="?left">
<meta name="variant" content="?letter-spacing">
<meta name="variant" content="?line-height">
<meta name="variant" content="?margin-bottom">
<meta name="variant" content="?margin-left">
<meta name="variant" content="?margin-right">
<meta name="variant" content="?margin-top">
<meta name="variant" content="?max-height">
<meta name="variant" content="?max-width">
<meta name="variant" content="?min-height">
<meta name="variant" content="?min-width">
<meta name="variant" content="?opacity">
<meta name="variant" content="?outline-color">
<meta name="variant" content="?outline-offset">
<meta name="variant" content="?outline-width">
<meta name="variant" content="?padding-bottom">
<meta name="variant" content="?padding-left">
<meta name="variant" content="?padding-right">
<meta name="variant" content="?padding-top">
<meta name="variant" content="?right">
<meta name="variant" content="?text-indent">
<meta name="variant" content="?text-shadow">
<meta name="variant" content="?top">
<meta name="variant" content="?vertical-align">
<meta name="variant" content="?visibility">
<meta name="variant" content="?width">
<meta name="variant" content="?word-spacing">
<meta name="variant" content="?z-index">
<meta name="assert" content="Check that all animatable CSS properties are animatable and then accepted by the 'transition-property' property">
<link rel="author" title="Daniel Glazman" href="mailto:daniel.glazman@disruptive-innovations.com">
<link rel="help" href="http://www.w3.org/TR/css3-transitions/#transitions">
Expand Down Expand Up @@ -86,19 +134,19 @@
["z-index", "1", "10", "", false]
];

// page timeout
var kTIMEOUT = 3000000;

var p = document.getElementById("testP");
var style = document.getElementById("newStyles");

var testsIntermediate = [];
var testsEnd = [];

setup({timeout: kTIMEOUT});
subsetTest = location.search ? location.search.substr(1) : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing var?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fixed


// create all the tests we need
for (var i = 0; i < kANIMATABLE_CSS_PROPERTIES.length; i++) {
if (subsetTest && kANIMATABLE_CSS_PROPERTIES[i][0] != subsetTest) {
continue;
}
testsIntermediate.push(async_test(kANIMATABLE_CSS_PROPERTIES[i][0] + " intermediate",
{ timeout: 2000, assert: "property " + kANIMATABLE_CSS_PROPERTIES[i][0] + " is animatable" }));
testsEnd.push(async_test(kANIMATABLE_CSS_PROPERTIES[i][0] + " end",
Expand Down