Wait until window load before calling window.stop() in XHR test #11091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://wpt.fyi/xhr/abort-after-stop.htm is broken in 3/4 browsers and it appears this is because calling window.stop() causes the window load event to never be fired, and testharness.js depends on that. There is no harness timeout in Edge, because Edge fires the load event. Tested with https://jsbin.com/tufepag/edit?js,console and filed #11090 for the lack of tests for this.
wpt-pr-bot
requested review from
annevk,
caitp,
emilio,
hallvors,
ibelem,
jdm,
jungkees,
kangxu,
Manishearth,
mathiasbynens,
ronkorving and
wisniewskit
jdm
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wpt.fyi/xhr/abort-after-stop.htm is broken in 3/4 browsers and
it appears this is because calling window.stop() causes the window
load event to never be fired, and testharness.js depends on that.
There is no harness timeout in Edge, because Edge fires the load
event. Tested with https://jsbin.com/tufepag/edit?js,console and filed
#11090 for the lack of
tests for this.