[LayoutNG] Avoid creating empty lines at bogus (unset) BFC offset 0,0. #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1098925
branch
from
9900116
to
4d08d88
Compare
This affects auto-positioned out-of-flow nodes that are handled as part of inline layout, and other things too. This fix will also make it possible to use the position of the last child fragment to calculate the block size of a block (which I happen to be working on). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie3f99d850de81bd349e89c624f86cce95b38eede Reviewed-on: https://chromium-review.googlesource.com/1098925 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567170}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1098925
branch
from
4d08d88
to
247ca84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects auto-positioned out-of-flow nodes that are handled as part
of inline layout, and other things too.
This fix will also make it possible to use the position of the last
child fragment to calculate the block size of a block (which I happen to
be working on).
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie3f99d850de81bd349e89c624f86cce95b38eede
Reviewed-on: https://chromium-review.googlesource.com/1098925
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#567170}