webrtc: add tooling to allow using jscodeshift codemods #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the tooling used in https://bugs.chromium.org/p/chromium/issues/detail?id=836871 to the WPT repository to allow anyone to run it. See https://github.com/facebook/jscodeshift for documentation on jscodeshift.
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
guidou,
henbos,
phoglund,
rwaldron,
snuggs and
youennf
alvestrand
reviewed
Jun 15, 2018
There was a problem hiding this comment.
A few nits to clean up; skipping lint (or the lint check for console.log) would make the bot enjoy it more.
I was reading about the magic of package-lock.json the other day; I didn't understand it. But if it's not going to be checked in, should it be added to .gitignore?
| export default function transformer(file, api) { | ||
| const j = api.jscodeshift; | ||
| return j(file.source) | ||
| // .forEach(path => console.log(path)) |
There was a problem hiding this comment.
Remove commented-out code?
webrtc/tools/html-codemod.js
Outdated
| // read back file, resubstitute | ||
| const newScript = fs.readFileSync(scriptFilename, 'utf-8').toString(); | ||
|
|
||
| // const modifiedContent = originalContent.replace(script[0], script[1] + newScript + script[script.length - 1]); |
There was a problem hiding this comment.
Delete obsolete(?) code?
alvestrand
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the tooling used in https://bugs.chromium.org/p/chromium/issues/detail?id=836871
to the WPT repository to allow anyone to run it.
See https://github.com/facebook/jscodeshift for documentation on jscodeshift.
@alvestrand if you want to test it out try running
node html-codemod.js codemod-peerconnection-addcleanup ../protocol/video-codecs.https.htmlfrom the tools directory.@foolip tagging you so you know there is something for codemods and can make introductions if someone asks about them or making large changes procedurally
Also removes package-lock.json. This is dev-tooling, a lock file makes no sense.