[Gecko Bug 1470530] [wdspec] Allow parametrization of "session" fixture and remove global "new_session" fixture. #11977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "new_session" fixture. With this patch the "session" fixture will make use of the new "capabilities" fixture to create WebDriver sessions with custom capabilities. It means the separate "new_session" fixture is no longer needed. Further the "session" fixture will only create a new session when the specified capabilities are different from the requested capabilities of the current session. To make it easier for tests to specify custom capabilities a marker with the same name has been created. It accepts a dict of capabilities as argument, and will then parametrize the current test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470530 gecko-commit: 1ec59d0783a52165b9d7b8e8c9b57e6ff9fde42b gecko-integration-branch: central gecko-reviewers: ato
With the WebDriver session created by the "session" fixture, there is no need anymore to pass a session instance to one of those methods. Instead the appropriate fixture can be used. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470530 gecko-commit: 2732ac33aac97da3f8f6b7d2fd7f8c748edc72fb gecko-integration-branch: central gecko-reviewers: ato
The "add_browser_capabilities" fixture is only used for new session tests, and as such makes sense to only expose the fixture for that specific sub directory. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470530 gecko-commit: bbccc02967d3eabdc30b32f4b33370c2a2a5d936 gecko-integration-branch: central gecko-reviewers: ato
By using yield for returning the session, there is no need to define all the finalizers. Instead those can be called right after the line with yield. To ease the usage of clean-up all individual clean-up methods are now called by the "cleanup_session" method in the correct order. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470530 gecko-commit: ea72ff9a6e23abf3aa52aaaf06a9ba8b18ca39c7 gecko-integration-branch: central gecko-reviewers: ato
wpt-pr-bot
approved these changes
Jul 13, 2018
|
Stability check will time out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch the "session" fixture will make use of the
new "capabilities" fixture to create WebDriver sessions with
custom capabilities. It means the separate "new_session"
fixture is no longer needed.
Further the "session" fixture will only create a new session
when the specified capabilities are different from the
requested capabilities of the current session.
To make it easier for tests to specify custom capabilities
a marker with the same name has been created. It accepts
a dict of capabilities as argument, and will then parametrize
the current test.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470530
gecko-commit: 1ec59d0783a52165b9d7b8e8c9b57e6ff9fde42b
gecko-integration-branch: central
gecko-reviewers: ato