[wptrunner] Fix regression in Sauce Labs browser #12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit [1] updated the invocation of the `start` method for "Browser" instances by introducing a new keyword argument. This interfered with the use of the "Sauce Labs" browser because its implementation of the `start` method did not accommodate any keyword arguments. Update the `start` method to support (but ignore) all keyword arguments. [1] 91803e3
jgraham
approved these changes
Jul 24, 2018
|
Not really good thoughts about how to test, other than actually running sauce. I suppose the other approach involves mocking out the actual sauce parts and just pretending to the code that we're running tests. Or, you know, using a language with a type system that can catch trivial errors… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit [1] updated the invocation of the
startmethod for"Browser" instances by introducing a new keyword argument. This
interfered with the use of the "Sauce Labs" browser because its
implementation of the
startmethod did not accommodate any keywordarguments.
Update the
startmethod to support (but ignore) all keyword arguments.[1] 91803e3
@jgraham do you have any thoughts on how we could test for this?