[URL] Add additional tests for URLSearchParams.sort() #12248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following tests for: * Parameter names with more than one character. * Parameter names with identical characters, but differing lengths. * Paramter names that are the empty string. * Parameter names that contain characters with the same number of code units.
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest,
Sebmaster,
smola and
TimothyGu
TimothyGu
reviewed
Jul 31, 2018
url/urlsearchparams-sort.html
Outdated
| { | ||
| "input": "bbb&bb&aaa&aa=x&aa=y", | ||
| "output": [ | ||
| ["aa", "x"], |
There was a problem hiding this comment.
Could you use the same indentation style as everywhere else?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following tests for: