Fix ref for external/wpt/svg/painting/reftests/paint-order-001.svg #12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 13, 2018
The property: paint-order: stroke markers is equivalent to: paint-order: stroke markers fill (Spec: "If any of the three keywords are omitted, they are painted last, in the order they would be painted with paint-order: normal." @ https://svgwg.org/svg2-draft/painting.html#PaintOrder ) So the fill should be painted last. Add 'marker:none' to the appropriate element in the ref. Disable stroke and marker in a few cases to avoid "overdraw" and thus "incorrect" edge rendering in some cases. BUG=872972 Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c Reviewed-on: https://chromium-review.googlesource.com/1172778 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582914}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1172778
branch
from
42b6005
to
1829d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property:
paint-order: stroke markers
is equivalent to:
paint-order: stroke markers fill
(Spec: "If any of the three keywords are omitted, they are painted last,
in the order they would be painted with paint-order: normal."
@ https://svgwg.org/svg2-draft/painting.html#PaintOrder )
So the fill should be painted last. Add 'marker:none' to the appropriate
element in the ref.
Disable stroke and marker in a few cases to avoid "overdraw" and thus
"incorrect" edge rendering in some cases.
BUG=872972
Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c
Reviewed-on: https://chromium-review.googlesource.com/1172778
Reviewed-by: Stephen Chenney schenney@chromium.org
Commit-Queue: Fredrik Söderquist fs@opera.com
Cr-Commit-Position: refs/heads/master@{#582914}