Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref for external/wpt/svg/painting/reftests/paint-order-001.svg #12457

Merged
merged 1 commit into from
Aug 14, 2018

Commits on Aug 14, 2018

  1. Fix ref for external/wpt/svg/painting/reftests/paint-order-001.svg

    The property:
    
      paint-order: stroke markers
    
    is equivalent to:
    
      paint-order: stroke markers fill
    
    (Spec: "If any of the three keywords are omitted, they are painted last,
     in the order they would be painted with paint-order: normal."
     @ https://svgwg.org/svg2-draft/painting.html#PaintOrder )
    
    So the fill should be painted last. Add 'marker:none' to the appropriate
    element in the ref.
    
    Disable stroke and marker in a few cases to avoid "overdraw" and thus
    "incorrect" edge rendering in some cases.
    
    BUG=872972
    
    Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c
    Reviewed-on: https://chromium-review.googlesource.com/1172778
    Reviewed-by: Stephen Chenney <schenney@chromium.org>
    Commit-Queue: Fredrik Söderquist <fs@opera.com>
    Cr-Commit-Position: refs/heads/master@{#582914}
    Fredrik Söderquist authored and Chrome-bot committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    1829d44 View commit details
    Browse the repository at this point in the history