Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XHR: statusText when using H2 #12490

Merged
merged 3 commits into from Oct 1, 2021
Merged

XHR: statusText when using H2 #12490

merged 3 commits into from Oct 1, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Aug 15, 2018

Fixes #7274.

@annevk annevk requested a review from dhdavvie August 15, 2018 08:15
@annevk
Copy link
Member Author

annevk commented Aug 15, 2018

This cannot land as H2 is not enabled by default.

@dhdavvie
Copy link
Contributor

It will also not work due to #12256, tests requiring H2 server cannot run on Travis currently afaik. But this test does work when run locally

@JosephPecoraro JosephPecoraro mentioned this pull request Oct 15, 2018
Closed
@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the annevk/xhr-h2-statusText branch January 24, 2020 18:02
@gsnedders gsnedders restored the annevk/xhr-h2-statusText branch January 24, 2020 18:47
@Hexcles Hexcles reopened this Jan 24, 2020
@annevk annevk enabled auto-merge (squash) October 1, 2021 16:20
andreubotella
andreubotella reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two different files? They seem identical other than the comment, and .window 2.js won't generate an HTML boilerplate.

@annevk
Copy link
Member Author

annevk commented Oct 1, 2021

Domenic at some point expressed a preference not to have fetch and XHR in the same file. I wouldn't be opposed to merging things more, but that'd be some work.

@andreubotella
Copy link
Member

Domenic at some point expressed a preference not to have fetch and XHR in the same file. I wouldn't be opposed to merging things more, but that'd be some work.

The two files are identical other than the initial comment, though.

@wpt-pr-bot wpt-pr-bot requested review from domfarolino, mnot, youennf and yutakahirano and removed request for ibelem October 1, 2021 16:41
@annevk
Copy link
Member Author

annevk commented Oct 1, 2021

My apologies, I blame iCloud and not paying close enough attention.

andreubotella
andreubotella approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annevk annevk merged commit 343538f into master Oct 1, 2021
@annevk annevk deleted the annevk/xhr-h2-statusText branch October 1, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhdavvie dhdavvie dhdavvie left review comments

@andreubotella andreubotella andreubotella approved these changes

@caitp caitp Awaiting requested review from caitp

@deniak deniak Awaiting requested review from deniak

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@emilio emilio Awaiting requested review from emilio

@gsnedders gsnedders Awaiting requested review from gsnedders

@jdm jdm Awaiting requested review from jdm

@jungkees jungkees Awaiting requested review from jungkees

@Manishearth Manishearth Awaiting requested review from Manishearth

@mathiasbynens mathiasbynens Awaiting requested review from mathiasbynens

@wisniewskit wisniewskit Awaiting requested review from wisniewskit

@zqzhang zqzhang Awaiting requested review from zqzhang

@domfarolino domfarolino Awaiting requested review from domfarolino

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@annevk annevk

Labels
fetch xhr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP/2 tests for statusText
6 participants
@annevk @dhdavvie @andreubotella @gsnedders @Hexcles @wpt-pr-bot