[Gecko Bug 1482496] Support list values in wptmanifest conditionals #12521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously considering the grammar for conditionals in wpt manifests to be something like: "if " expr ":" string This excluded the possibilty of complex values on the RHS. Here we change it to the more obvious (and intended) "if " expr ":" value Differential Revision: https://phabricator.services.mozilla.com/D3127 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1482496 gecko-commit: ae52877671adab5f4a00e7887c6806dc26aa7cfa gecko-integration-branch: autoland gecko-reviewers: ato
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously considering the grammar for conditionals in wpt
manifests to be something like:
"if " expr ":" string
This excluded the possibilty of complex values on the RHS. Here we
change it to the more obvious (and intended)
"if " expr ":" value
Differential Revision: https://phabricator.services.mozilla.com/D3127
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1482496
gecko-commit: ae52877671adab5f4a00e7887c6806dc26aa7cfa
gecko-integration-branch: autoland
gecko-reviewers: ato