Fix cookie prefix tests. #12543
Merged
Fix cookie prefix tests. #12543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 17, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179150
branch
2 times, most recently
from
7ae5a65
to
fb1c840
Compare
The layout tests aren't testing much at the moment, as they're never served over HTTPS. This patch creates `.https` versions of the tests and reworks them to actually exercise the behavior of `__Host` and `__Secure` cookie prefixes. Bug: 843945 Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8 Reviewed-on: https://chromium-review.googlesource.com/1179150 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584016}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179150
branch
from
fb1c840
to
0771560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout tests aren't testing much at the moment, as they're never
served over HTTPS. This patch creates
.httpsversions of the testsand reworks them to actually exercise the behavior of
__Hostand__Securecookie prefixes.Bug: 843945
Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8
Reviewed-on: https://chromium-review.googlesource.com/1179150
Commit-Queue: Mike West mkwst@chromium.org
Reviewed-by: Mike West mkwst@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#584016}