Avoid overflowing snap areas in scrollTo wpt tests #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 23, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1182299
branch
from
8a7601c
to
0d7744b
Compare
Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard. This is caused by the uncertainty of the window size for testharness tests. If the window size becomes small enough that the snap area covers the snapport, the expected snap position is ignored because any scroll position is considered a valid snap position. This patch changes the landing position of scrollTo and scrollBy for failing cases so that the snap area does not cover ths snapport regardless of the window size. More specifically, the snap area's vertical and horizontal dimensions are 600px each thus covering the [1000, 1600] range with expected snap position at 1000. Previously if the test vertically scrolled to 1200 and the window's size is smaller than 400, the snap area will cover the window. Now the test scrolls to 900 (100px before the snap position), ensuring that the target snap area won't cover the window regardless of the size. Bug: 876052 Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901 Reviewed-on: https://chromium-review.googlesource.com/1182299 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585926}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1182299
branch
from
0d7744b
to
c5ae577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard.
This is caused by the uncertainty of the window size for testharness
tests. If the window size becomes small enough that the snap area covers
the snapport, the expected snap position is ignored because any scroll
position is considered a valid snap position. This patch changes the
landing position of scrollTo and scrollBy for failing cases so that the
snap area does not cover ths snapport regardless of the window size.
More specifically, the snap area's vertical and horizontal dimensions
are 600px each thus covering the [1000, 1600] range with expected snap
position at 1000. Previously if the test vertically scrolled to 1200 and
the window's size is smaller than 400, the snap area will cover the
window. Now the test scrolls to 900 (100px before the snap position),
ensuring that the target snap area won't cover the window regardless of
the size.
Bug: 876052
Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901
Reviewed-on: https://chromium-review.googlesource.com/1182299
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Reviewed-by: Majid Valipour majidvp@chromium.org
Cr-Commit-Position: refs/heads/master@{#585926}