Limit the use of sudo: required to Travis jobs that need it
#13424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the jobs that do `source tools/ci/lib.sh`. Note that the "stability (Chrome Dev)" job already (redundantly) specified `sudo: required`. The hosts addon functionality isn't needed. The hosts list is out of date, and tools/ci/lib.sh does the hosts fixup when needed.
|
https://travis-ci.org/web-platform-tests/wpt/builds/438648140 can be used to evaluate if this made things faster the the jobs that ran fully in both, which is only lint. There, it's actually slower, not faster. Even though sudo is no longer in the job config, it seems like it's the same sort of VM/container/whatever in both cases. So probably best to just leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the jobs that do
source tools/ci/lib.sh. Note that the"stability (Chrome Dev)" job already (redundantly) specified
sudo: required.The hosts addon functionality isn't needed. The hosts list is out of
date, and tools/ci/lib.sh does the hosts fixup when needed.