[Gecko Bug 1498680] Fix wpt runner's browser stop implementation: request stop before waiting #13501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting The current implementation waits for fennec to stop before trying to stop it - easy enough to address. At the same time, I am updating the runner stop implementation to try stop_application before kill: stop_application shuts down the application more cleanly; kill should only be used as a backup. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498680 gecko-commit: 54598c1940f1b4cf12c1e122431ce709237c686f gecko-integration-branch: mozilla-inbound gecko-reviewers: kwierso
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation waits for fennec to stop before trying to stop it - easy enough
to address. At the same time, I am updating the runner stop implementation to try
stop_application before kill: stop_application shuts down the application more
cleanly; kill should only be used as a backup.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498680
gecko-commit: 54598c1940f1b4cf12c1e122431ce709237c686f
gecko-integration-branch: mozilla-inbound
gecko-reviewers: kwierso