Tao null opaque origin test #13507
Closed
Tao null opaque origin test #13507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
haoxli,
igrigorik,
plehegar,
toddreifsteck and
zqzhang
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Feb 15, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for web-platform-tests#13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Feb 18, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for web-platform-tests#13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Feb 18, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for web-platform-tests#13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Feb 26, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for web-platform-tests#13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Feb 26, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for web-platform-tests#13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
gsnedders
added a commit
that referenced
this pull request
Feb 26, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for #13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
yoavweiss
force-pushed
the
TAO-null-opaque-origin
branch
from
ba07ade
to
27e953d
Compare
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] #13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898
|
Obsoleted by #15782 |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 15, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] #13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 15, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] #13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 15, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] #13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 15, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 1, 2019
…ts and make sure they pass, a=testonly Automatic update from web-platform-tests [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123} -- wpt-commits: b90e1587455350962c4efc39b7c1bbf588d6ab64 wpt-pr: 15782
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Apr 2, 2019
…ts and make sure they pass, a=testonly Automatic update from web-platform-tests [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123} -- wpt-commits: b90e1587455350962c4efc39b7c1bbf588d6ab64 wpt-pr: 15782
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
This hasn't been used by anyone in several years, and trying to fix the tests as part of the work for #13507 tends to suggest that the chunker is itself broken. It is, in many ways, the least useful chunker as it results in test execution order changing every time the test execution time metadata is updated, and this leads to further flakiness.
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] #13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ts and make sure they pass, a=testonly Automatic update from web-platform-tests [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#641123} -- wpt-commits: b90e1587455350962c4efc39b7c1bbf588d6ab64 wpt-pr: 15782 UltraBlame original commit: 3d2c191f504c051a25b6d265d1804d9f42d73f62
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ts and make sure they pass, a=testonly Automatic update from web-platform-tests [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#641123} -- wpt-commits: b90e1587455350962c4efc39b7c1bbf588d6ab64 wpt-pr: 15782 UltraBlame original commit: 3d2c191f504c051a25b6d265d1804d9f42d73f62
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ts and make sure they pass, a=testonly Automatic update from web-platform-tests [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] web-platform-tests/wpt#13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#641123} -- wpt-commits: b90e1587455350962c4efc39b7c1bbf588d6ab64 wpt-pr: 15782 UltraBlame original commit: 3d2c191f504c051a25b6d265d1804d9f42d73f62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests w3c/resource-timing#172
Makes sure that a
Timing-Allow-Origin: 'null'header enables detailed timing for opaque origins.