Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tip note in text-transform/ tests #13509

Merged
merged 2 commits into from Oct 15, 2018

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Oct 14, 2018

Fixes #13505.

The PR removes the Tip note entirely in all the text-transform/ tests that include such note. As commented, in #13505 there might be a part of the tip that is relevant. I can reintroduce it if it's valuable. I think in case that part of the tip needs to be rephrased.

In addition, the PR removes some extra whitespace in the html tag of many tests.

@frivoal
Copy link
Contributor

frivoal commented Oct 14, 2018

Looks good to me, approved.

However, I'm not sure why the travis task failed when testing stability on firefox. I've restarted it for now, but if it keeps on failing we'll have to look into it.

@frivoal
Copy link
Contributor

frivoal commented Oct 14, 2018

Still failing. Looks like an infrastructure problem to me, but I'm not sure.
@gsnedders @foolip @Ms2ger Any idea how to interpret this failure (and what to do about it)? https://travis-ci.org/web-platform-tests/wpt/jobs/441391903

@sideshowbarker
Copy link
Contributor

Still failing. Looks like an infrastructure problem to me, but I'm not sure.
@gsnedders @foolip @Ms2ger Any idea how to interpret this failure (and what to do about it)? https://travis-ci.org/web-platform-tests/wpt/jobs/441391903

Raised #13513

@foolip
Copy link
Member

foolip commented Oct 15, 2018

Thanks for reporting! Let me admin merge this, it's still possible to investigate by creating an equivalent PR from the same point in history.

@foolip foolip merged commit 71d0ec4 into web-platform-tests:master Oct 15, 2018
@r12a
Copy link
Contributor

r12a commented Oct 16, 2018

See my comment at #13505 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants